Conversation
For version 3 traces, recordSize is read from the file and used to advance the reader without any check. A record size of 0 makes the record loops in both the regular and streaming parsers never reach EOF, so the parser keeps appending the same record until it runs out of memory. A 73-byte file is enough to trigger this. Reject record sizes smaller than the minimum 10 bytes when reading the header, and reject records whose fields need more bytes than the record size allows, which covers the 14-byte dual clock case.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6333 +/- ##
==========================================
+ Coverage 83.92% 84.03% +0.11%
==========================================
Files 353 354 +1
Lines 37969 38107 +138
Branches 10604 10765 +161
==========================================
+ Hits 31865 32023 +158
+ Misses 5675 5656 -19
+ Partials 429 428 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main | Deploy preview
For version 3 traces, recordSize is read from the file and used to advance the reader without any check. A record size of 0 makes the record loops in both the regular and streaming parsers never reach EOF, so the parser keeps appending the same record until it runs out of memory. A 73-byte file is enough to trigger this.
Reject record sizes smaller than the minimum 10 bytes when reading the header, and reject records whose fields need more bytes than the record size allows, which covers the 14-byte dual clock case.