feat!: Kill ScaleDetector in favour of ScaleCallbacks - #3996
Merged
Conversation
luanpotter
marked this pull request as ready for review
August 14, 2026 05:19
spydon
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Kill
ScaleDetectormixin and associated code from old infra in favour ofScaleCallbacks.Minor differences:
ScaleGestureRecognizeralso fired scale events for a single pointer, which the zoom example exploited to pan.MultiDragScaleGestureRecognizeronly fires scale once two or more pointers are down, so the example and the docs now combineScaleCallbackswithDragCallbacks, which is the intended way to do pan + pinch in the new system and no longer needs the oldPanDetector/ScaleDetectorconflict workaround. The drag handler skips panning while isScaling, since a pinch emits drag events for each pointer as well.ScaleGestureRecognizerhandlesPointerPanZoom*events viaaddAllowedPointerPanZoom, which is how a trackpad pinch reaches a scale recognizer.MultiDragScaleGestureRecognizerdoes not implement this, so nor does our new detectors; however that is an existing gap, and we can close it on followups. This is tangential to this cleanup.Checklist
docsand added dartdoc comments with///.examplesordocs.Breaking Change?