remove the compiled library. - #14
Merged
Merged
Conversation
bsoe-flexiv
requested review from
ZhipengZhang-flexiv,
munseng-flexiv,
pzhu-flexiv,
rdwang-flexiv and
zfquek-flexiv
August 21, 2026 15:29
pzhu-flexiv
approved these changes
Aug 21, 2026
Stop committing libflexiv_sim_plugin.x86_64-linux-gnu.a to the repo.
Only its .sha256 checksum is tracked in lib/; the .a itself is attached
to the matching GitHub release (v${PROJECT_VERSION}) as an asset, and
CMake downloads and verifies it against the checksum at configure time.
Also regenerate the public headers from flexiv_sim_plugin_impl for the
v1.3.0 release (wrist force/torque in SimRobotStates).
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
bsoe-flexiv
force-pushed
the
feature/move-binary-to-release-asset
branch
from
August 21, 2026 20:46
2de24e0 to
aeba022
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the compiled library. The cmake package will download it from the release package. The binary will be added to the github release package as an asset.