fix(flow-php/web): render each mermaid diagram into its own wrapper - #2580
Merged
Conversation
- own diagram ids instead of mermaid.run() timestamps - create panzoom and listeners once, tear down on disconnect - self-host mermaid, load it lazily off the CDN, initialize once per theme change - hide the wrapper until its diagram is drawn - cover MermaidCodeRenderer markup with unit tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #2362
Change Log
Added
flow-php/web- self-hosted mermaid, loaded lazily only on pages with a diagramFixed
flow-php/web- diagrams drawn on top of each other because mermaid derived ids from the clockflow-php/web- panzoom instances and zoom listeners leaking on every theme toggleChanged
flow-php/web- mermaid is initialized once per theme change instead of once per diagramflow-php/web- diagram wrapper stays hidden until its diagram is drawnRemoved
flow-php/web- render-blocking mermaid CDN script loaded on every pageDeprecated
Security