fix(flow-php/symfony-telemetry-bundle): resolve definition classes in compiler passes - #2584
Merged
Merged
Conversation
… compiler passes - add DefinitionClassResolver walking parent chains and %parameter% classes - trace cache pools inheriting their class from a parent - skip abstract definitions in Psr18ClientTelemetryPass, fixing container build crash - register invalidation resources via getReflectionClass() instead of class_exists() - extract duplicated exclude-pattern matching into ServiceIdPatterns
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 1.x #2584 +/- ##
=========================================
Coverage 86.30% 86.31%
+ Complexity 23675 23673 -2
=========================================
Files 1816 1818 +2
Lines 71924 71921 -3
=========================================
+ Hits 62076 62080 +4
+ Misses 9848 9841 -7 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #xxx
Change Log
Added
flow-php/symfony-telemetry-bundle-DefinitionClassResolverresolving a definition class through parent chains and%parameter%placeholdersflow-php/symfony-telemetry-bundle-ServiceIdPatternsmatching a service id against exact ids and regular expressionsflow-php/symfony-telemetry-bundle- unit and integration tests forCacheTelemetryPassandPsr18ClientTelemetryPassFixed
flow-php/symfony-telemetry-bundle- cache pools inheriting their class from a parent definition are now tracedflow-php/symfony-telemetry-bundle- pools and PSR-18 clients whose class is a%parameter%are now tracedflow-php/symfony-telemetry-bundle-Psr18ClientTelemetryPassno longer decorates abstract definitions and breaks the container buildflow-php/symfony-telemetry-bundle-instrumentation.cache.exclude_poolsnow takes effect for framework poolsChanged
flow-php/symfony-telemetry-bundle- class lookup usesContainerBuilder::getReflectionClass()so container invalidation resources are registeredflow-php/symfony-telemetry-bundle- exclude pattern matching extracted out of the compiler passes intoServiceIdPatternsRemoved
Deprecated
Security