Skip to content

[material_ui] Migrate M3 FilterChip template to use new gen_defaults - #12849

Draft
QuncCccccc wants to merge 1 commit into
flutter:mainfrom
QuncCccccc:filter_chip_m3_defaults_migration
Draft

[material_ui] Migrate M3 FilterChip template to use new gen_defaults#12849
QuncCccccc wants to merge 1 commit into
flutter:mainfrom
QuncCccccc:filter_chip_m3_defaults_migration

Conversation

@QuncCccccc

Copy link
Copy Markdown
Contributor

Work toward flutter/flutter#187899.
Fixes flutter/flutter#188416.

Depends on #12848. Will wait until #12848 lands first.

Migrates the M3 FilterChip defaults template to the new packages/material_ui/tool/gen_defaults generator.

Pre-Review Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools.
  • I read the [Tree Hygiene] page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran [the auto-formatter].
  • I signed the [CLA].
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I [linked to at least one issue that this PR fixes] in the description above.
  • I followed [the version and CHANGELOG instructions], using [semantic versioning] and the [repository CHANGELOG style], or I have commented below to indicate which documented exception this PR falls under[^1].
  • I updated/added any relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or I have commented below to indicate which [test exemption] this PR falls under[^1].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Sep 12, 2026
@QuncCccccc
QuncCccccc marked this pull request as draft September 12, 2026 04:20
@github-actions github-actions Bot added p: material_ui triage-design Should be looked at in design triage labels Sep 12, 2026
@QuncCccccc QuncCccccc changed the title [material_ui] Migrate M3 FilterChip template to use new gen_defaults [material_ui] Migrate M3 FilterChip template to use new gen_defaults Sep 12, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request migrates the generation of Material 3 defaults for FilterChip to a token-based template system. It removes the inline _FilterChipDefaultsM3 class from filter_chip.dart and references it as a generated part file. It introduces FilterChipTemplateM3 to generate these defaults, enables the template in the generator script, and adds unit tests to verify the generated output. There are no review comments, and I have no feedback to provide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CICD Run CI/CD p: material_ui triage-design Should be looked at in design triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

filter_chip_template.dart

1 participant