[flutter_plugin_tools] Use Flutter pub for packages depending on jni - #12857
Draft
awishere wants to merge 1 commit into
Draft
[flutter_plugin_tools] Use Flutter pub for packages depending on jni#12857awishere wants to merge 1 commit into
awishere wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Packages with a
jnidependency can require the Flutter SDK even when their pubspec has no direct Flutter SDK dependency. The publishing tool currently selectsdart pub publishfor this case, causing dependency resolution to fail for packages such aspigeon.Recognize
jniin both dependencies and dev dependencies in the shared Flutter-requirement check. This follows the narrow known-dependency approach suggested in the issue and also applies to the other pub commands using that helper. It does not attempt to resolve arbitrary transitive dependency graphs.Fixes flutter/flutter#192709.
Validation (Dart 3.12.2, macOS arm64, from
script/tool):dart pub publishinstead offlutter pub publish.dart test— all 1,238 tests passed, including existing direct-Flutter and Dart-only behavior.dart analyze— no issues found.dart format --set-exit-if-changed .— 106 files, no changes.git diff --check— passed.Publishing is exercised through the existing mocked process runner; no package was published.
Prepared with Codex assistance. This PR is a draft pending the contributor's personal review of the code and description under Flutter's AI contribution guidelines. CLA status has not yet been verified.
Pre-Review Checklist
[shared_preferences]///).Footnotes
The tool version is incremented to
0.14.4+2and its changelog records the fix. Validation covers the completeflutter_plugin_toolstest suite, not unrelated plugin suites. ↩ ↩2