Skip to content

Add Apple Disk Image (DMG) support - #88

Open
joost-j wants to merge 1 commit into
fox-it:mainfrom
joost-j:feature/dmg
Open

Add Apple Disk Image (DMG) support#88
joost-j wants to merge 1 commit into
fox-it:mainfrom
joost-j:feature/dmg

Conversation

@joost-j

@joost-j joost-j commented Aug 4, 2026

Copy link
Copy Markdown

Add support for .dmg files containing the UDIF file format. Some macOS acquisition tools, for example Fuji, are able to create DMG outputs. This PR enables users to directly interact with those resulting disk images without needing to convert them first. Supports the different sub-formats, as well as encrypted DMG's.

I've been thinking about committing this code to the dissect.disc repo first, but since that is specifically targeting filesystems for optical media, I figured this repository is a better fit. DMG does not have it's own filesystem and is mainly a wrapper around a disk, much like other formats in this repo (e.g. vmdk/vhd). If this code belongs in another dissect project, please let me know.

Test data was created manually on a MacBook with the hdiutil tool and converted to the individual sub-formats. The code was generated with Claude Code and manually reviewed / edited to fit the dissect code base; this greatly contributed to the completeness of the implementation, as well as the time to get it done. So if you were wondering why the docstrings and struct annotations are so detailed; that's why. Any feedback with regards to the use of Claude Code is also appreciated.

Requires fox-it/dissect.util#131 for the ADC compression.

@joost-j joost-j changed the title Add Apple Disk Image (DMG) container Add Apple Disk Image (DMG) support Aug 4, 2026
@Schamper

Schamper commented Aug 4, 2026

Copy link
Copy Markdown
Member

What about dissect.archive? I know it's all "what's in a name" in the end, but, you know.

@joost-j

joost-j commented Aug 4, 2026

Copy link
Copy Markdown
Author

Yes that could also be an option, though most of the implementations in dissect.archive function as a basis for filesystem implementations and not really raw disks; there isn't a single container in dissect.target which uses a container from dissect.archive.

One could argue that DMG (in terms of vendor/basic capabilities) comes close to the ASIF file format, which was placed in this repo as well. However, ASIF is actually used for virtualization purposes, as opposed to DMG. EWF/ASDF are also very similar, but DMG lacks the forensic evidence features. A third option would be a separate dissect.diskimage or something alike which will hold ASIF/DMG, but that's overkill maybe.

Though it's not a clean fit, my choice would still be this repo but I'll let you make the call.

@DissectBot

Copy link
Copy Markdown

@joost-j thank you for your contribution! As this is your first code contribution, please read the following Contributor License Agreement (CLA). If you agree with the CLA, please reply with the following information:

@DissectBot agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
Contributor License Agreement

Contribution License Agreement

This Contribution License Agreement ("Agreement") governs your Contribution(s) (as defined below) and conveys certain license rights to Fox-IT B.V. ("Fox-IT") for your Contribution(s) to Fox-IT"s open source Dissect project. This Agreement covers any and all Contributions that you ("You" or "Your"), now or in the future, Submit (as defined below) to this project. This Agreement is between Fox-IT B.V. and You and takes effect when you click an “I Accept” button, check box presented with these terms, otherwise accept these terms or, if earlier, when You Submit a Contribution.

  1. Definitions.
    "Contribution" means any original work of authorship, including any modifications or additions to an existing work, that is intentionally submitted by You to Fox-IT for inclusion in, or documentation of, any of the software products owned or managed by, or on behalf of, Fox-IT as part of the Project (the "Work").
    "Project" means any of the projects owned or managed by Fox-IT and offered under a license approved by the Open Source Initiative (www.opensource.org).
    "Submit" means any form of electronic, verbal, or written communication sent to Fox-IT or its representatives, including but not limited to communication on electronic mailing lists, source code control systems, and issue tracking systems that are managed by, or on behalf of, Fox-IT for the purpose of discussing and improving the Work, but excluding communication that is conspicuously marked or otherwise designated in writing by You as "Not a Contribution."

  2. Grant of Copyright License. Subject to the terms and conditions of this Agreement, You hereby grant to Fox-IT and to recipients of software distributed by Fox-IT a perpetual, worldwide, non-exclusive, no-charge, royalty-free, irrevocable copyright license to reproduce, prepare derivative works of, publicly display, publicly perform, sublicense, and distribute Your Contributions and such derivative works.

  3. Grant of Patent License. Subject to the terms and conditions of this Agreement, You hereby grant to Fox-IT and to recipients of software distributed by Fox-IT a perpetual, worldwide, non-exclusive, no-charge, royalty-free, irrevocable (except as stated in this section) patent license to make, have made, use, maintain, offer to sell, sell, import, and otherwise transfer the Work, where such license applies only to those patent claims licensable by You that are necessarily infringed by Your Contribution(s) alone or by combination of Your Contribution(s) with the Work to which such Contribution(s) was submitted. If any entity institutes patent litigation against You or any other entity (including a cross-claim or counterclaim in a lawsuit) alleging that your Contribution, or the Work to which you have contributed, constitutes direct or contributory patent infringement, then any patent licenses granted to that entity under this Agreement for that Contribution or Work shall terminate as of the date such litigation is filed.

  4. Representations. You represent that:

    • You are legally entitled to grant the above license.
    • each of Your Contributions is Your original creation (see section 8 for submissions on behalf of others).
    • Your Contribution submissions include complete details of any third-party license or other restriction (including, but not limited to, related patents and trademarks) of which you are personally aware and which are associated with any part of Your Contributions.
  5. Employer. If Your Contribution is made in the course of Your work for an employer or Your employer has intellectual property rights in Your Submission by contract or applicable law, You must secure permission from Your employer to make the Contribution before signing this Agreement. In that case, the term "You" in this Agreement will refer to You and the employer collectively. If You change employers in the future and desire to Submit additional Contribution for the new employer, then You agree to sign a new Agreement and secure permission from the new employer before Submitting those Contributions.

  6. Support. You are not expected to provide support for Your Contribution, unless You choose to do so. Any such support provided to the Project is provided free of charge.

  7. Warranty. Unless required by applicable law or agreed to in writing, You provide Your Contributions on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied, including, without limitation, any warranties or conditions of TITLE, NON-INFRINGEMENT, MERCHANTABILITY, or FITNESS FOR A PARTICULAR PURPOSE.

  8. Third party material. Should You wish to submit work that is not Your original creation, You may only submit it to Fox-IT separately from any Contribution, identifying the complete details of its source and of any license or other restriction (including, but not limited to, related patents, trademarks, and license agreements) of which You are personally aware, and conspicuously marking the work as "Submitted on behalf of a third-party: [named here]".

  9. Notify. You agree to notify Fox-IT of any facts or circumstances of which You become aware that would make the above representations inaccurate in any respect.

  10. Governing law / competent court. This Agreement is governed by the laws of the Netherlands. Any disputes that may arise are resolved by arbitration in accordance with the Arbitration Regulations of the Foundation for the Settlement of Automation Disputes (Stichting Geschillenoplossing Automatisering – SGOA – (www.sgoa.eu), this without prejudice to either party"s right to request preliminary relief in preliminary relief proceedings or arbitral preliminary relief proceedings. Arbitration proceedings take place in Amsterdam, or in any other place designated in the Arbitration Regulations. Arbitration shall take place in English.

@joost-j

joost-j commented Sep 2, 2026

Copy link
Copy Markdown
Author

@DissectBot agree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants