Skip to content

fix(upgrade): nightly discovery hits wrong GHCR package (silent 404 → full-download fallback) #1304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BYK merged 1 commit into from
Jul 27, 2026
Merged

fix(upgrade): nightly discovery hits wrong GHCR package (silent 404 → full-download fallback) #1304

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/lib/delta-upgrade.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ import { CLI_VERSION } from "./constants.js";
import { customFetch } from "./custom-ca.js";
import { getConfigDir } from "./db/index.js";
import { formatBytes } from "./formatters/numbers.js";
import { GHCR_REPO } from "./ghcr.js";
import { logger } from "./logger.js";
import { makeByteProgress, type SetMessage } from "./progress.js";
import { withTracing, withTracingSpan } from "./telemetry.js";
Expand All @@ -67,7 +68,9 @@ export type DeltaResult = {
chainLength: number;
};

const GITHUB_REPO_REPO_NAME = "getsentry/sentry-cli";
// GHCR publishes nightlies to ghcr.io/getsentry/cli (see src/lib/ghcr.ts
// GHCR_REPO). Importing as a named import keeps a single source of truth and
// avoids the silent 404 introduced when this was a string literal.
const log = logger.withTag("delta-upgrade");

const instrument: InstrumentHook = (name, fn) =>
Expand Down Expand Up @@ -129,7 +132,7 @@ function stableSource(): SourceStrategy {
function nightlySource(): SourceStrategy {
return ghcrSource({
registry: "https://ghcr.io",
repo: GITHUB_REPO_REPO_NAME,
repo: GHCR_REPO,
binaryName: getPlatformBinaryName(),
targetTag: (version) => `nightly-${version}`,
compareVersions,
Expand Down Expand Up @@ -274,7 +277,7 @@ export async function resolveNightlyChain(opts: {
}): Promise<PatchChain | null> {
const client = new OciClient({
registry: "https://ghcr.io",
repo: GITHUB_REPO_REPO_NAME,
repo: GHCR_REPO,
userAgent: `sentry-cli/${CLI_VERSION}`,
fetch: customFetch,
});
Expand Down
Loading