ref(service): Standardize backend session token codecs - #616
Open
lcian wants to merge 1 commit into
Open
Conversation
Give concrete backends typed session-token codecs while keeping resumable methods object-safe and preserving the opaque wire format.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## ref/generalize-encryption-cipher #616 +/- ##
====================================================================
- Coverage 89.20% 89.15% -0.06%
====================================================================
Files 110 110
Lines 19036 19057 +21
====================================================================
+ Hits 16981 16990 +9
- Misses 2055 2067 +12
☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
Author
|
bugbot run |
Member
Author
|
I'm not sure if this change is beneficial, wdyt @jan-auer? |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 99c42b0. Configure here.
lcian
marked this pull request as ready for review
September 8, 2026 15:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backends can now define a sized session-token representation and centralize its codec while the
object-safe resumable API continues passing an opaque
BackendToken. GCS owns the first typedimplementation and decodes tokens at each resumable operation boundary; decorators and backends
without resumable support continue forwarding or rejecting opaque tokens as before.
BackendTokenis now a serde-transparent newtype, so its JSON representation, encrypted sessionenvelope, and GCS
total_length.session_uriencoding remain wire-compatible. This PR is stacked on#615, which provides the generalized encryption boundary used by these tokens.
A disadvantage of this approach is that the backend-specific types need to become
pub, as they become part of theBackendAPI which ispubitself.