Skip to content

feat(android-nav3): [Android Nav3 4] Introduce SentryNavEffect - #6109

Merged
0xadam-brown merged 1 commit into
feat/android-nav3-module-stackfrom
feat/android-nav3-module-4-effect
Sep 16, 2026
Merged

0xadam-brown merged 1 commit into
feat/android-nav3-module-stackfrom
feat/android-nav3-module-4-effect

Conversation

@0xadam-brown

@0xadam-brown 0xadam-brown commented Sep 12, 2026

Copy link
Copy Markdown
Member

PR Stack (Android Nav3)


📜 Description

Introduce SentryNavEffect, the Compose-facing abstraction for Android Nav3.

This final stack step connects the observer layer to Compose lifecycle and recomposition behavior,
and adds tests around effect lifetime, extractor updates, and back stack identity handling.

💡 Motivation and Context

SentryNavEffect is the key abstraction this integration presents to host apps. Keeping it in its
own PR makes the public-facing shape and lifecycle model reviewable on their own, even while the
symbol remains internal for now.

💚 How did you test it?

  • ./gradlew :sentry-android-navigation3:testReleaseUnitTest
  • ./gradlew spotlessApply
  • ./gradlew apiDump

📝 Checklist

  • I added GH Issue ID & Linear ID
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.
  • Public API changes reviewed by another Mobile SDK team member or implemented according to the develop docs spec.

🔮 Next steps

Expose the effect publicly and follow up with docs, samples, and any profiling-specific polish.

#skip-changelog

⚠️ Merge this PR using a merge commit (not squash). Only the collection branch is squash-merged into main.

@github-actions

github-actions Bot commented Sep 12, 2026

Copy link
Copy Markdown
Contributor
Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against ec8bdd9

@sentry

sentry Bot commented Sep 12, 2026

Copy link
Copy Markdown

📲 Install Builds

Android

🔗 App Name App ID Version Configuration
SDK Size io.sentry.tests.size 8.56.0 (1) release

⚙️ sentry-android Build Distribution Settings

@0xadam-brown 0xadam-brown added the deep-dive PR needs a thorough review of design, behavior, and edge cases label Sep 12, 2026
Add the Compose-facing abstraction that binds Navigation 3 back stack changes to the observer layer. This establishes the integration’s primary API shape while keeping it internal until the rest of the sequence is ready to expose it.
@0xadam-brown
0xadam-brown force-pushed the feat/android-nav3-module-4-effect branch from 98d868d to ec8bdd9 Compare September 16, 2026 03:31
Base automatically changed from feat/android-nav3-module-3-observer to feat/android-nav3-module-stack September 16, 2026 03:31
@0xadam-brown
0xadam-brown merged commit ec8bdd9 into feat/android-nav3-module-stack Sep 16, 2026
1 check was pending
@0xadam-brown
0xadam-brown deleted the feat/android-nav3-module-4-effect branch September 16, 2026 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deep-dive PR needs a thorough review of design, behavior, and edge cases

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant