-
-
Notifications
You must be signed in to change notification settings - Fork 478
feat(android): Recover MemoryLimiter app exits on startup (JAVA-687) #6111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
7db4b30
161483e
cc0773d
2d4d066
cdcff5c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -587,6 +587,8 @@ private void setDist( | |
| timestamp = ((AbnormalExit) hint).timestamp(); | ||
| } else if (hint instanceof NativeCrashExit) { | ||
| timestamp = ((NativeCrashExit) hint).timestamp(); | ||
| } else if (hint instanceof MemoryLimiterIntegration.MemoryLimiterHint) { | ||
| timestamp = ((MemoryLimiterIntegration.MemoryLimiterHint) hint).timestamp(); | ||
| } else { | ||
| timestamp = null; | ||
| } | ||
|
|
@@ -800,9 +802,7 @@ private final class AnrHintEnricher implements HintEnricher { | |
|
|
||
| @Override | ||
| public boolean supports(@NotNull Object hint) { | ||
| // While this is specifically an ANR enricher we discriminate enrichment application | ||
| // on the broader AbnormalExit hints for now. | ||
| return hint instanceof AbnormalExit; | ||
| return hint instanceof AnrV2Integration.AnrV2Hint; | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Note: AbnormalExit has two implementations: AnrV2Hint and AnrHint. We can safely ignore AnrHint here because ApplicationExitInfoEventProcessor only processes hints that are Backfillable, and AnrHint isn't. That's a clarity win, too, because AnrHint belongs to the older ANR flow that doesn't make use of ApplicationExitInfo. |
||
| } | ||
|
|
||
| // by default we assume that the ANR is foreground, unless abnormalMechanism is "anr_background" | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TombstonePolicy is
@ApiStatus.Internal.