Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 12 additions & 10 deletions .agents/skills/skill-creator/agents/comparator.md
Original file line number Diff line number Diff line change
Expand Up @@ -39,18 +39,20 @@ You receive these parameters in your prompt:
Based on the task, generate a rubric with two dimensions:

**Content Rubric** (what the output contains):
| Criterion | 1 (Poor) | 3 (Acceptable) | 5 (Excellent) |
|-----------|----------|----------------|---------------|
| Correctness | Major errors | Minor errors | Fully correct |
| Completeness | Missing key elements | Mostly complete | All elements present |
| Accuracy | Significant inaccuracies | Minor inaccuracies | Accurate throughout |

| Criterion | 1 (Poor) | 3 (Acceptable) | 5 (Excellent) |
| ------------ | ------------------------ | ------------------ | -------------------- |
| Correctness | Major errors | Minor errors | Fully correct |
| Completeness | Missing key elements | Mostly complete | All elements present |
| Accuracy | Significant inaccuracies | Minor inaccuracies | Accurate throughout |

**Structure Rubric** (how the output is organized):
| Criterion | 1 (Poor) | 3 (Acceptable) | 5 (Excellent) |
|-----------|----------|----------------|---------------|
| Organization | Disorganized | Reasonably organized | Clear, logical structure |
| Formatting | Inconsistent/broken | Mostly consistent | Professional, polished |
| Usability | Difficult to use | Usable with effort | Easy to use |

| Criterion | 1 (Poor) | 3 (Acceptable) | 5 (Excellent) |
| ------------ | ------------------- | -------------------- | ------------------------ |
| Organization | Disorganized | Reasonably organized | Clear, logical structure |
| Formatting | Inconsistent/broken | Mostly consistent | Professional, polished |
| Usability | Difficult to use | Usable with effort | Easy to use |

Adapt criteria to the specific task. For example:

Expand Down
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3266,6 +3266,7 @@ await compiled.invoke({
<summary> <strong>Internal Changes</strong> </summary>

- chore(build): Fix incorrect versions after merge ([#18154](https://github.com/getsentry/sentry-javascript/pull/18154))

</details>

## 10.24.0
Expand Down Expand Up @@ -3294,6 +3295,7 @@ await compiled.invoke({
- chore(eslint): Add eslint-plugin-regexp rule (dev-packages) ([#18063](https://github.com/getsentry/sentry-javascript/pull/18063))
- test(next): fix flakey tests ([#18100](https://github.com/getsentry/sentry-javascript/pull/18100))
- test(node-core): Proof that withMonitor doesn't create a new trace ([#18057](https://github.com/getsentry/sentry-javascript/pull/18057))

</details>

## 10.23.0
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,7 @@ import { RouterOutlet } from '@angular/router';
selector: 'app-root',
standalone: true,
imports: [RouterOutlet],
template: `
<router-outlet></router-outlet>
`,
template: ` <router-outlet></router-outlet> `,
})
export class AppComponent {
title = 'angular-17';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@ import { Component } from '@angular/core';
@Component({
selector: 'app-cancel',
standalone: true,
template: `
<div></div>
`,
template: ` <div></div> `,
})
export class CancelComponent {}
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,7 @@ import { Component, OnInit } from '@angular/core';
@Component({
selector: 'app-sample-component',
standalone: true,
template: `
<div></div>
`,
template: ` <div></div> `,
})
export class SampleComponent implements OnInit {
ngOnInit() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,7 @@ import { RouterOutlet } from '@angular/router';
selector: 'app-root',
standalone: true,
imports: [RouterOutlet],
template: `
<router-outlet></router-outlet>
`,
template: ` <router-outlet></router-outlet> `,
})
export class AppComponent {
title = 'angular-18';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@ import { Component } from '@angular/core';
@Component({
selector: 'app-cancel',
standalone: true,
template: `
<div></div>
`,
template: ` <div></div> `,
})
export class CancelComponent {}
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,7 @@ import { SampleComponent } from '../sample-component/sample-component.components
selector: 'app-cancel',
standalone: true,
imports: [TraceModule, SampleComponent],
template: `
<app-sample-component [trace]="'sample-component'"></app-sample-component>
`,
template: ` <app-sample-component [trace]="'sample-component'"></app-sample-component> `,
})
@TraceClass({ name: 'ComponentTrackingComponent' })
export class ComponentTrackingComponent implements OnInit, AfterViewInit {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,7 @@ import { Component, OnInit } from '@angular/core';
@Component({
selector: 'app-sample-component',
standalone: true,
template: `
<div>Component</div>
`,
template: ` <div>Component</div> `,
})
export class SampleComponent implements OnInit {
ngOnInit() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,7 @@ import { RouterOutlet } from '@angular/router';
selector: 'app-root',
standalone: true,
imports: [RouterOutlet],
template: `
<router-outlet></router-outlet>
`,
template: ` <router-outlet></router-outlet> `,
})
export class AppComponent {
title = 'angular-19';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@ import { Component } from '@angular/core';
@Component({
selector: 'app-cancel',
standalone: true,
template: `
<div></div>
`,
template: ` <div></div> `,
})
export class CancelComponent {}
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,7 @@ import { Component, OnInit } from '@angular/core';
@Component({
selector: 'app-sample-component',
standalone: true,
template: `
<div>Component</div>
`,
template: ` <div>Component</div> `,
})
export class SampleComponent implements OnInit {
ngOnInit() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,7 @@ import { RouterOutlet } from '@angular/router';
selector: 'app-root',
standalone: true,
imports: [RouterOutlet],
template: `
<router-outlet></router-outlet>
`,
template: ` <router-outlet></router-outlet> `,
})
export class AppComponent {
title = 'angular-20';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@ import { Component } from '@angular/core';
@Component({
selector: 'app-cancel',
standalone: true,
template: `
<div></div>
`,
template: ` <div></div> `,
})
export class CancelComponent {}
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,7 @@ import { Component, OnInit } from '@angular/core';
@Component({
selector: 'app-sample-component',
standalone: true,
template: `
<div>Component</div>
`,
template: ` <div>Component</div> `,
})
export class SampleComponent implements OnInit {
ngOnInit() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,7 @@ import { RouterOutlet } from '@angular/router';
selector: 'app-root',
standalone: true,
imports: [RouterOutlet],
template: `
<router-outlet></router-outlet>
`,
template: ` <router-outlet></router-outlet> `,
})
export class AppComponent {
title = 'angular-21';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@ import { Component } from '@angular/core';
@Component({
selector: 'app-cancel',
standalone: true,
template: `
<div></div>
`,
template: ` <div></div> `,
})
export class CancelComponent {}
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,7 @@ import { Component, OnInit } from '@angular/core';
@Component({
selector: 'app-sample-component',
standalone: true,
template: `
<div>Component</div>
`,
template: ` <div>Component</div> `,
})
export class SampleComponent implements OnInit {
ngOnInit() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,7 @@ import { RouterOutlet } from '@angular/router';
standalone: true,
imports: [RouterOutlet],
changeDetection: ChangeDetectionStrategy.OnPush,
template: `
<router-outlet></router-outlet>
`,
template: ` <router-outlet></router-outlet> `,
})
export class AppComponent {
title = 'angular-22';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@ import { ChangeDetectionStrategy, Component } from '@angular/core';
selector: 'app-cancel',
standalone: true,
changeDetection: ChangeDetectionStrategy.OnPush,
template: `
<div></div>
`,
template: ` <div></div> `,
})
export class CancelComponent {}
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,7 @@ import { ChangeDetectionStrategy, Component, OnInit } from '@angular/core';
selector: 'app-sample-component',
standalone: true,
changeDetection: ChangeDetectionStrategy.OnPush,
template: `
<div>Component</div>
`,
template: ` <div>Component</div> `,
})
export class SampleComponent implements OnInit {
ngOnInit() {
Expand Down
14 changes: 3 additions & 11 deletions docs/changelog/v8.md
Original file line number Diff line number Diff line change
Expand Up @@ -63,9 +63,7 @@ import { withSentry } from '@sentry/solidstart';

export default defineConfig(
withSentry(
{
/* Your SolidStart config options... */
},
{/* Your SolidStart config options... */},
{
// Options for setting up source maps
org: process.env.SENTRY_ORG,
Expand All @@ -86,9 +84,7 @@ Now, there are two options to set up the SDK:
2. Add `autoInjectServerSentry: 'top-level-import'` and the Sentry config will be imported at the top of the server entry (comes with tracing limitations)
```js
withSentry(
{
/* Your SolidStart config options... */
},
{/* Your SolidStart config options... */},
{
// Optional: Install Sentry with a top-level import
autoInjectServerSentry: 'top-level-import',
Expand Down Expand Up @@ -643,11 +639,7 @@ The Nuxt SDK now allows you to track Pinia state for captured errors. To enable
import { usePinia } from '#imports';

Sentry.init({
integrations: [
Sentry.piniaIntegration(usePinia(), {
/* optional Pinia plugin options */
}),
],
integrations: [Sentry.piniaIntegration(usePinia(), {/* optional Pinia plugin options */})],
});
```

Expand Down
9 changes: 1 addition & 8 deletions docs/migration/v8-to-v9.md
Original file line number Diff line number Diff line change
Expand Up @@ -319,14 +319,7 @@ All exports and APIs of `@sentry/utils` and `@sentry/types` (except for the ones
import { withSentry } from '@sentry/solidstart';

export default defineConfig(
withSentry(
{
/* SolidStart config */
},
{
/* Sentry build-time config (like project and org) */
},
),
withSentry({/* SolidStart config */}, {/* Sentry build-time config (like project and org) */}),
);
```

Expand Down
10 changes: 5 additions & 5 deletions docs/new-sdk-release-checklist.md
Original file line number Diff line number Diff line change
Expand Up @@ -67,17 +67,17 @@ order**. Note that you can prepare the PRs at any time but the **merging oder**

### Before the Release:

- [ ] 1. If not yet done, be sure to remove the `private: true` property from your SDK’s `package.json`. Additionally,
- [ ] 1. If not yet done, be sure to remove the `private: true` property from your SDK’s `package.json`. Additionally,
ensure that `"publishConfig": {"access": "public"}` is set.
- [ ] 2. Add an `npm` target in `craft.yml` for the new package. Make sure to insert it in the right place, after all
- [ ] 2. Add an `npm` target in `craft.yml` for the new package. Make sure to insert it in the right place, after all
the Sentry dependencies of your package but before packages that depend on your new package (if applicable).
```yml
- name: npm
id: '@sentry/[yourPackage]'
includeNames: /^sentry-[yourPackage]-\d.*\.tgz$/
```
- [ ] 3. Add a `registry` target in `craft.yml` for the new package.
For new packages, Craft will automatically create the required directory structure and initial manifest in the Sentry Release Registry ([Craft Docs](https://craft.sentry.dev/targets/registry/#creating-new-packages)).
For new packages, Craft will automatically create the required directory structure and initial manifest in the Sentry Release Registry ([Craft Docs](https://craft.sentry.dev/targets/registry/#creating-new-packages)).
```yml
name: 'Sentry [Package] SDK'
sdkName: 'sentry.javascript.[package]'
Expand All @@ -86,14 +86,14 @@ order**. Note that you can prepare the PRs at any time but the **merging oder**
onlyIfPresent: /^sentry-[package]-\d.*\.tgz$/
```
- [ ] 4. Cut a new release (as usual, see
[Publishing Release](https://github.com/getsentry/sentry-javascript/blob/develop/docs/publishing-a-release.md))
[Publishing Release](https://github.com/getsentry/sentry-javascript/blob/develop/docs/publishing-a-release.md))

### After the Release

- [ ] 1. Check that the package was in fact published to NPM
- [ ] 2. Check that the SDK is added to the Sentry Release Registry [npm packages](https://github.com/getsentry/sentry-release-registry/tree/master/packages/npm/%40sentry) and [SDK symlinks](https://github.com/getsentry/sentry-release-registry/tree/master/sdks)
- [ ] 3. In case the package is missing anywhere, add the missing content. Instructions on how to do this can be found [here](https://github.com/getsentry/sentry-release-registry#adding-new-sdks)
[Example PR](https://github.com/getsentry/sentry-release-registry/pull/80) from the Svelte SDK.
[Example PR](https://github.com/getsentry/sentry-release-registry/pull/80) from the Svelte SDK.

## Follow-up Tasks

Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@
"nodemon": "^3.1.10",
"npm-run-all2": "^6.2.0",
"nx": "22.7.5",
"oxfmt": "^0.38.0",
"oxfmt": "^0.60.0",
"oxlint": "^1.75.0",
"oxlint-tsgolint": "7",
"rimraf": "^5.0.10",
Expand Down
10 changes: 5 additions & 5 deletions packages/cloudflare/src/vite/moduleShape.ts
Original file line number Diff line number Diff line change
Expand Up @@ -100,21 +100,21 @@ export function shapeFromAst(ast: ProgramBody): ModuleShape {
for (const node of ast.body) {
switch (node.type) {
case 'ClassDeclaration':
addAstClass(shape, node as ClassNode);
addAstClass(shape, node);
break;
case 'ImportDeclaration':
addAstImports(shape, node as ImportDeclarationNode);
addAstImports(shape, node);
break;
case 'ExportNamedDeclaration':
addAstNamedExport(shape, node as ExportNamedNode);
addAstNamedExport(shape, node);
break;
case 'ExportDefaultDeclaration': {
const decl = (node as ExportDefaultNode).declaration;
if (decl.type === 'ClassDeclaration' || decl.type === 'ClassExpression') {
shape.defaultExportIsClass = true;
shape.defaultExportSuper = superRefFromNode((decl as ClassNode).superClass);
// `export default class Foo {}` also binds `Foo` locally.
addAstClass(shape, decl as ClassNode);
addAstClass(shape, decl);
} else if (decl.type === 'Identifier') {
shape.defaultExportName = (decl as IdentifierNode).name;
}
Expand Down Expand Up @@ -174,7 +174,7 @@ function addAstImports(shape: ModuleShape, node: ImportDeclarationNode): void {

function addAstNamedExport(shape: ModuleShape, node: ExportNamedNode): void {
if (node.declaration?.type === 'ClassDeclaration') {
addAstClass(shape, node.declaration as ClassNode);
addAstClass(shape, node.declaration);
return;
}

Expand Down
2 changes: 1 addition & 1 deletion packages/core/src/exports.ts
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ export function setAttributes<T extends Record<string, unknown>>(attributes: Raw
*/
export function setAttribute<
// oxlint-disable-next-line typescript-eslint/no-explicit-any
T extends RawAttribute<T> extends { value: any } | { unit: any } ? AttributeObject : unknown,
T extends (RawAttribute<T> extends { value: any } | { unit: any } ? AttributeObject : unknown),

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this I find interesting: I thought formatters tried to avoid unnecessary brackets as much as possible. I have no objections to adding the brackets here but just wondering if you know why it chose to add them. Anyway, just curious not a blocker for this PR

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea, when I looked it seemed like this one introduced it oxc-project/oxc#24450 but no reasoning is given.

>(key: string, value: RawAttribute<T>): void {
getIsolationScope().setAttribute(key, value);
}
Expand Down
Loading
Loading