ref(core): Remove otel-based suppressTracing implementation - #22574
Merged
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
size-limit report 📦
|
mydea
force-pushed
the
fn/suppressTracing
branch
2 times, most recently
from
July 27, 2026 11:29
e8aa6c4 to
b7af61f
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit b7af61f. Configure here.
mydea
force-pushed
the
fn/suppressTracing
branch
from
July 27, 2026 12:00
b7af61f to
cda341c
Compare
mydea
marked this pull request as ready for review
July 27, 2026 12:00
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Comment on lines
102
to
107
| startSpanManual, | ||
| startInactiveSpan, | ||
| getActiveSpan, | ||
| suppressTracing, | ||
| isTracingSuppressed, | ||
| getTraceData, | ||
| continueTrace, | ||
| startNewTrace, |
Contributor
There was a problem hiding this comment.
Bug: Removing the custom suppressTracing implementation for OTEL causes Sentry.suppressTracing() to no longer suppress OTEL-native span creation, as it now only sets Sentry-scope metadata.
Severity: HIGH
Suggested Fix
Reinstate the custom suppressTracing implementation in the OTEL async context strategy (asyncContextStrategy.ts). This implementation should call the native OpenTelemetry suppressTracing() function from @opentelemetry/core to ensure the suppression signal is correctly propagated within the OTEL context, which is what the OTEL tracer and propagator check.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: packages/opentelemetry/src/asyncContextStrategy.ts#L102-L107
Potential issue: In OpenTelemetry environments, the removal of the custom
`suppressTracing` implementation in `asyncContextStrategy.ts` causes a fallback to the
default Sentry implementation. This default only sets a `SUPPRESS_TRACING_KEY` in the
Sentry scope metadata. However, the OTEL tracer and propagator check for suppression
using OTEL's native context mechanism from `@opentelemetry/core`. Because the Sentry
metadata is not checked by OTEL, calling `Sentry.suppressTracing()` will fail to prevent
the creation of OTEL-native spans and the propagation of trace headers.
Did we get this right? 👍 / 👎 to inform future reviews.
andreiborza
approved these changes
Jul 27, 2026
andreiborza
left a comment
andreiborza
left a comment
Member
There was a problem hiding this comment.
Nice, one less thing to maintain!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now, by default suppress tracing is async context aware, and we only overwrite this for the stack strategy (in browser) to have special handling (which used to be the default). node, cloudflare, deno can all use the default implementation.