feat(core)!: Enable logs by default - #22630
Merged
Merged
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit ce5221b. Configure here.
Contributor
size-limit report 📦
|
nicohrubec
force-pushed
the
feat/enable-logs-by-default
branch
from
July 24, 2026 14:08
5a51b06 to
721edd9
Compare
nicohrubec
marked this pull request as ready for review
July 24, 2026 14:47
nicohrubec
requested review from
JPeer264 and
isaacs
and removed request for
a team
July 24, 2026 14:47
isaacs
approved these changes
Jul 26, 2026
JPeer264
requested changes
Jul 28, 2026
Flip the `enableLogs` client option to default to `true`, mirroring `enableMetrics`. No logs are emitted unless the logger API is called or a logging integration is explicitly enabled, since no default integration captures logs. Fixes #20639 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The client constructor backfills `enableLogs` onto its options, so the strict `getOptions()` equality check now needs the resolved default. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Flush the log buffer before capturing the sentinel error so a leaked log envelope arrives first and fails the ordered `event` expectation. Previously the error was sent first and the runner could complete before a stray log arrived, letting a broken disable path pass. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The constructor already backfills `enableLogs` from `_experiments.enableLogs`, so re-reading `_experiments` in the capture guard was dead code. Reduce it to a plain destructure default, matching the original shape. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The default has now been flipped, so the "or change default value" branch of the TODO is done. Narrow it to removing the deprecated experimental flag, matching the adjacent enableMetrics TODO. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
nicohrubec
force-pushed
the
feat/enable-logs-by-default
branch
from
July 29, 2026 08:16
10618d3 to
e5f2c76
Compare
nicohrubec
requested review from
chargome,
logaretm,
msonnb and
s1gr1d
and removed request for
a team,
chargome,
logaretm,
msonnb and
s1gr1d
July 29, 2026 08:16
Logs default to `true` now, so the JSDoc note that the logger API and logging integrations require `enableLogs` to be enabled is no longer accurate. Drop the clause, the redundant `enableLogs: true` from init examples/READMEs, and the `_experiments.enableLogs` flag from the shared browser logger test init. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
nicohrubec
force-pushed
the
feat/enable-logs-by-default
branch
from
July 29, 2026 08:22
e5f2c76 to
8a28f39
Compare
Member
Author
|
@JPeer264 made another pass to remove some more references, there is still a few left which are needed for specific tests |
chargome
approved these changes
Jul 29, 2026
chargome
left a comment
chargome
left a comment
Member
There was a problem hiding this comment.
Looks good! I did a quick scan and I think none of the integrations are enabled by default 👍
Keep in mind we also need to change the default in the loader script once this is released.
Member
Author
|
@chargome thanks for the reminder, added a ticket for this on linear to our v11 follow up tasks |
JPeer264
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This flips the
enableLogsclient option to default totrueso users get Sentry Logs without opting in manually, matching howenableMetricsalready behaves. Nothing is captured unless theSentry.loggerAPI is called or a logging integration is explicitly enabled, and an explicitenableLogs: falsestill turns it off.Fixes #20639