ref(node): Remove vendored redis/ioredis instrumentation - #22753
Draft
andreiborza wants to merge 1 commit into
Draft
ref(node): Remove vendored redis/ioredis instrumentation#22753andreiborza wants to merge 1 commit into
andreiborza wants to merge 1 commit into
Conversation
Removes the dead OpenTelemetry redis and ioredis instrumentations (and their shared semconv constants) from `@sentry/node`. The redis integration is provided by the channel-based implementation in `@sentry/server-utils` (default since #22501); the node `redisIntegration` wrapper and its `cache.ts` (plus the `vendored/types.ts` it still imports) are kept. Ref: #22346 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the dead vendored OpenTelemetry
redisandioredisinstrumentations (and their sharedsemconv.ts) from@sentry/node. Keeps theredisIntegrationwrapper,cache.ts, and thevendored/types.tsthatcache.tsstill imports.Why
The redis integration is now provided by the channel-based implementation in
@sentry/server-utils(the default since #22501). The vendored OTel instrumentations are no longer wired into the SDK, so they are pure dead code.Ref: #22346