feat(node)!: Make dataloader and knex integrations channel-only - #22754
Merged
Conversation
Removes the vendored OpenTelemetry fallback from the node `dataloaderIntegration` and `knexIntegration`, re-exporting the channel-based implementations from `@sentry/server-utils` directly. Previously these fell back to the vendored OTel instrumentation on runtimes without diagnostics-channel injection; they are now channel-only, consistent with the other performance integrations. Ref: #22346 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
chargome
approved these changes
Jul 28, 2026
JPeer264
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the vendored OpenTelemetry fallback from the node
dataloaderIntegrationandknexIntegration. They are now re-exported directly from@sentry/server-utils, matching the other channel-based integrations.Why
These were the only two integrations still keeping a vendored OTel instrumentation as a runtime fallback (used when diagnostics-channel injection was unavailable). Making them channel-only removes the last vendored DB instrumentation and aligns them with every other integration since channel-based became the default (#22501).
Note: on runtimes without diagnostics-channel injection (e.g. Bun, Deno, older Node, or when injection fails), these integrations no longer produce spans, consistent with the other integrations.
Ref: #22346