test(nextjs): Add E2E assertions for use cache functions - #24301
Merged
Conversation
Contributor
size-limit report 📦
|
chargome
approved these changes
Sep 11, 2026
Comment on lines
+105
to
+107
| // The dev server serves `use cache` entries past their `expire` limit, so the expiry path only | ||
| // exists in production builds. | ||
| test.skip(process.env.TEST_ENV !== 'production', 'Entries only hard-expire in production'); |
Member
There was a problem hiding this comment.
q: What does this mean exactly for dev then?
Member
Author
There was a problem hiding this comment.
In dev, entries aren't discarded when their expire time passes. next dev keeps a use cache entry for at least 5 minutes (MIN_PRERENDERABLE_EXPIRE), even when its expire is shorter.
I'm gonna make that more clear in the comment (but I'll add it in the other PR to avoid conflicts).
s1gr1d
added a commit
that referenced
this pull request
Sep 11, 2026
First merge: #24301 `use cache` reads and writes are invisible in traces. This wraps `get`/`set` on Next's cache-handler registry (`@next/cache-handlers-map`, plus the dev-only private handler) with `cache.get`/`cache.put` spans. Decisions: - Keys are SHA-1 digests, because raw keys serialize function arguments (PII). - `cache.hit` mirrors Next: entries past `expire` count as misses. Tag discards stay hits (undetectable at the handler). - Hits carry `cache.item_age`, `cache.ttl`, and `cache.tags`. The first and last are pending sentry-conventions upstreaming. - Guards live on `globalThis` (the module loads once per bundle). Both initorderings work: `next start` and dev server. Related to #12888. But the legacy incremental cache (fetch/ISR) stays uncovered. **Cache Fill** <img width="813" height="282" alt="image" src="https://github.com/user-attachments/assets/bd1a5e84-4c7c-40a5-9651-8670f6ff3726" /> --- **Cache Get** <img width="805" height="135" alt="image" src="https://github.com/user-attachments/assets/875ba0c1-f222-4f26-a6bd-7b545101067e" /> Closes #24289
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of this issue: #24289
and also the E2E tests: #24290