feat(solid-start): Add code.function.name attribute to solid-start function spans - #24316
Open
Lms24 wants to merge 2 commits into
Open
feat(solid-start): Add code.function.name attribute to solid-start function spans#24316Lms24 wants to merge 2 commits into
code.function.name attribute to solid-start function spans#24316Lms24 wants to merge 2 commits into
Conversation
…`function` spans
Lms24
marked this pull request as ready for review
September 10, 2026 15:46
Lms24
requested review from
mydea and
s1gr1d
and removed request for
a team
September 10, 2026 15:46
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similarly to #24305, this PR adds the
code.function.nameattribute tofunctionspans from the solidStart SDK. Span names are already low card. and function names, so nothing to do other than ensuring that span description inference works via the new attribute.