ref(browser): Use conventions constants for browser navigation attributes - #24322
Open
logaretm wants to merge 1 commit into
Open
ref(browser): Use conventions constants for browser navigation attributes#24322logaretm wants to merge 1 commit into
logaretm wants to merge 1 commit into
Conversation
Lms24
approved these changes
Sep 10, 2026
Contributor
size-limit report 📦
|
…utes Replaces the locally-defined `browser.navigation.type` placeholder and the `browser.soft_navigation.id` attribute with `BROWSER_NAVIGATION_TYPE` and `BROWSER_NAVIGATION_ID` from `@sentry/conventions`.
logaretm
force-pushed
the
awad/browser-navigation-attributes
branch
from
September 10, 2026 18:16
969f6b8 to
9ebbdb9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Swaps our two locally-defined browser navigation attribute constants for the ones now published in
@sentry/conventions0.23.0.