feat(remix): Emit low cardinality function span names - #24323
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 6e8c390. Configure here.
| expect(getSpanOp(documentRequestSpan!)).toBe('function'); | ||
| expect(documentRequestSpan!.attributes['sentry.origin']?.value).toBe('auto.function.remix'); | ||
| // The span name is low cardinality now, so the description carries the name it used to have. | ||
| expect(documentRequestSpan!.attributes['sentry.description']?.value).toBe(segment.name); |
There was a problem hiding this comment.
DocumentRequest E2E tests target wrong apps
Medium Severity
The new documentRequest E2E tests run against Node Remix apps that never create that span. documentRequest spans are only emitted when instrumentTracing is on, which Node init does not enable. The tests fail and do not cover the patched Cloudflare path that actually produces the span.
Additional Locations (1)
Triggered by project rule: PR Review Guidelines for Cursor Bot
Reviewed by Cursor Bugbot for commit 6e8c390. Configure here.
1 participant
This PR adjusts a few remix
functionspans so that their name becomes low cardinality. "Lost" information is retained in extra attributes and tests are adjusted. Also used thesentry.descriptionoverride again because none of the names can be mapped via description inference properly.