test(e2e): Cover soft navigation web vitals across router instrumentations - #24324
Open
logaretm wants to merge 1 commit into
Open
test(e2e): Cover soft navigation web vitals across router instrumentations#24324logaretm wants to merge 1 commit into
logaretm wants to merge 1 commit into
Conversation
…tions Soft navigation vitals correlate to a navigation span through the interaction that triggered it, so the correlation only holds while the span is started before that interaction's Event Timing entry is delivered. Every router instrumentation starts its span at a different point, and none of them start it on the history change, so each is worth pinning down separately. Covers react-router v6 component routes (layout effect), a react-router data router (deferred until the router goes idle, i.e. after loaders resolve, the latest of the four), Vue (`router.beforeEach`) and Angular (router event stream). TanStack Router is left out: the app that runs it with span streaming (solid-tanstack-router) currently cannot install because of an upstream dependency, and the one that does install (tanstack-router) is on the static trace lifecycle, where soft navigation vitals do not apply.
logaretm
added this pull request to stack #24274
September 10, 2026 18:20
Contributor
size-limit report 📦
|
Member
Author
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 38b211f. Configure here.
logaretm
marked this pull request as ready for review
September 10, 2026 19:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an e2e test per router instrumentation asserting that a soft navigation's web vitals are attributed to the navigation span they were measured on.
This covers most frameworks that can reliably test this, tanstack seems to have an edge case that I need to investigate separately.