Skip to content

chore: Drop dual tracing helpers - #7479

Merged
sentrivana merged 1 commit into
major/3.0from
ivana/major/remove-_set_span_data_attribute
Sep 11, 2026
Merged

chore: Drop dual tracing helpers#7479
sentrivana merged 1 commit into
major/3.0from
ivana/major/remove-_set_span_data_attribute

Conversation

@sentrivana

@sentrivana sentrivana commented Sep 11, 2026

Copy link
Copy Markdown
Contributor
  • Remove Spans from type annotations in integrations
  • Remove helpers like set_on_span, set_span_data_attribute

Taking at least some stuff out of #7468 to make it more reviewable

@sentrivana
sentrivana marked this pull request as ready for review September 11, 2026 13:57
@sentrivana
sentrivana requested a review from a team as a code owner September 11, 2026 13:57
@github-actions

Copy link
Copy Markdown
Contributor

Codecov Results 📊

67586 passed | ⏭️ 3304 skipped | Total: 70890 | Pass Rate: 95.34% | Execution Time: 214m 41s

📊 Comparison with Base Branch

Metric Change
Total Tests 📉 -68076
Passed Tests 📉 -64249
Failed Tests
Skipped Tests 📉 -3827

All tests are passing successfully.

✅ Patch coverage is 97.10%. Project has 2708 uncovered lines.
❌ Project coverage is 87.86%. Comparing base (a97f270) to head (6081103).

Files with missing lines (1)
File Patch % Lines
sentry_sdk/integrations/google_genai/utils.py 50.00% ⚠️ 2 Missing
Coverage diff
@@            Coverage Diff             @@
##        master       #PR       +/-##
==========================================
- Coverage    90.18%    87.86%    -2.32%
==========================================
  Files          193       181       -12
  Lines        25790     22310     -3480
  Branches      9532      8114     -1418
==========================================
+ Hits         23258     19602     -3656
- Misses        2532      2708      +176
- Partials      1432      1237      -195

Generated by Codecov Action

@sentrivana
sentrivana merged commit c625381 into major/3.0 Sep 11, 2026
149 checks passed
@sentrivana
sentrivana deleted the ivana/major/remove-_set_span_data_attribute branch September 11, 2026 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants