feat(data-collection): Add sensitive key-value collection filter - #3025
Open
sl0thentr0py wants to merge 1 commit into
Open
feat(data-collection): Add sensitive key-value collection filter#3025sl0thentr0py wants to merge 1 commit into
sl0thentr0py wants to merge 1 commit into
Conversation
sl0thentr0py
force-pushed
the
neel/data-collection/sensitive
branch
2 times, most recently
from
July 20, 2026 12:54
caa24a5 to
6a1469f
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
sl0thentr0py
force-pushed
the
neel/data-collection/sensitive
branch
from
July 20, 2026 12:57
6a1469f to
29d2ec4
Compare
sl0thentr0py
force-pushed
the
neel/data-collection/sensitive
branch
from
July 20, 2026 13:02
29d2ec4 to
d86858a
Compare
sl0thentr0py
force-pushed
the
neel/data-collection/sensitive
branch
from
July 20, 2026 13:10
d86858a to
284c040
Compare
sl0thentr0py
force-pushed
the
neel/data-collection/sensitive
branch
from
July 20, 2026 14:11
284c040 to
801ff01
Compare
sl0thentr0py
force-pushed
the
neel/data-collection/sensitive
branch
2 times, most recently
from
July 20, 2026 14:13
d90c1b7 to
e649ed3
Compare
sl0thentr0py
force-pushed
the
neel/data-collection/sensitive
branch
from
July 20, 2026 14:31
e649ed3 to
2672657
Compare
sl0thentr0py
force-pushed
the
neel/data-collection/sensitive
branch
2 times, most recently
from
July 21, 2026 14:24
53393da to
6f61522
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 6f61522. Configure here.
sl0thentr0py
force-pushed
the
neel/data-collection/sensitive
branch
from
July 22, 2026 11:49
6f61522 to
e3d1a05
Compare
sl0thentr0py
force-pushed
the
neel/data-collection/sensitive
branch
from
July 22, 2026 12:07
e3d1a05 to
a0dcc7a
Compare
sl0thentr0py
force-pushed
the
neel/data-collection/sensitive
branch
from
July 22, 2026 12:11
a0dcc7a to
e3d1a05
Compare
sl0thentr0py
force-pushed
the
neel/data-collection/sensitive
branch
2 times, most recently
from
July 22, 2026 16:19
ea1251f to
97bdffe
Compare
sl0thentr0py
force-pushed
the
neel/data-collection/sensitive
branch
from
July 22, 2026 16:23
97bdffe to
ea1251f
Compare
dingsdax
approved these changes
Jul 24, 2026
solnic
reviewed
Jul 28, 2026
solnic
left a comment
solnic
left a comment
Collaborator
There was a problem hiding this comment.
Left some non-blocking comments.
| end | ||
|
|
||
| def terms=(terms) | ||
| @terms = terms&.map { |term| term.to_s.downcase }&.reject { |term| term.strip.empty? } |
Collaborator
There was a problem hiding this comment.
Can't we default to an empty array ie DEFAULT_TERMS frozen constant, so that it's clear that this thing works with an array, and then we could just do terms.any? { ... } in the matching methods?
| it "covers every built-in sensitive term" do | ||
| values = Sentry::DataCollection::KeyValueCollection::SENSITIVE_DENY_LIST.to_h do |term| | ||
| ["prefix-#{term.upcase}-suffix", "value"] | ||
| end |
Collaborator
There was a problem hiding this comment.
I'd also add lowcased terms + some other keys just to fully cover behavior that it covers defaults and leaves the rest. Otherwise this test is very narrow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
KeyValueCollectionfiltering behavior for:off, :allow_list, :deny_listIssues
Stack created with GitHub Stacks CLI • Give Feedback 💬