Skip to content

Ab/create tooltip component for annotations - #124233

Draft
adrianviquez wants to merge 2 commits into
sarajmanes/dain-1849-fe-dropped-data-annotationsfrom
ab/create-tooltip-component-for-annotations
Draft

Ab/create tooltip component for annotations#124233
adrianviquez wants to merge 2 commits into
sarajmanes/dain-1849-fe-dropped-data-annotationsfrom
ab/create-tooltip-component-for-annotations

Conversation

@adrianviquez

Copy link
Copy Markdown
Contributor

This is a WIP tooltip component for the annotations work.

Caveats / missing:

  • API only sends droppedCount today, but we're the outcomes accepted by amount and by bytes
  • "Click for Details" will be done in a separate PR

Closes DAIN-1852

@adrianviquez

Copy link
Copy Markdown
Contributor Author

@cursor review

@linear-code

linear-code Bot commented Sep 12, 2026

Copy link
Copy Markdown

DAIN-1852

@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Sep 12, 2026

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit fdad5a3. Configure here.

@github-actions

Copy link
Copy Markdown
Contributor

📊 Type Coverage Diff

Metric Before After Delta
Coverage 95.48% 95.47% 🔴 -0.01%
Typed 139,392 139,418 🟢 +26
Untyped 6,603 6,609 🔴 +6
🔍 6 new type safety issues introduced

Non-null assertions (!) (6 new)

File Line Detail
static/app/views/explore/components/chart/droppedDataBand/droppedDataTooltip.tsx 70 acceptedCount!
static/app/views/explore/components/chart/droppedDataBand/droppedDataTooltip.tsx 77 droppedBytes!
static/app/views/explore/components/chart/droppedDataBand/droppedDataTooltip.tsx 77 acceptedBytes!
static/app/views/explore/components/chart/droppedDataBand/droppedDataTooltip.tsx 98 countTotal!
static/app/views/explore/components/chart/droppedDataBand/droppedDataTooltip.tsx 104 droppedBytes!
static/app/views/explore/components/chart/droppedDataBand/droppedDataTooltip.tsx 105 byteTotal!

This is informational only and does not block the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant