fix(workflow): Eliminate N+1 queries in workflow serializers - #124245
Draft
sentry[bot] wants to merge 2 commits into
Draft
fix(workflow): Eliminate N+1 queries in workflow serializers#124245sentry[bot] wants to merge 2 commits into
sentry[bot] wants to merge 2 commits into
Conversation
…group serializers
github-actions
Bot
added
the
Scope: Backend
sentry
Bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses an N+1 query issue identified in the
WorkflowSerializerandDataConditionGroupSerializerwhen fetching related objects.Specifically:
WorkflowSerializer.get_attrs,WorkflowDataConditionGroupobjects were being iterated over, causing an N+1 query for eachcondition_groupaccess. This is fixed by adding.select_related("condition_group")to the queryset.DataConditionGroupSerializer.get_attrs,DataConditionGroupActionobjects were similarly causing an N+1 query for eachactionaccess. This is fixed by adding.select_related("action")to the queryset.Regression tests have been added to both
test_workflow_serializer.pyandtest_data_condition_group_serializer.pyto ensure that bulk serialization no longer results in an increasing number of database queries.CI failures related to mypy (missing return type annotations for helper functions) and ruff-format (line length/formatting) in the new test code have also been resolved.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Fixes SENTRY-5P73
@sentry <feedback>: Autofix iterates on these changes@sentry stop iterating: Autofix stops iterating on this runThis PR was automatically generated by Sentry. You can adjust this setting at any time.