Skip to content

CONTRIBUTING.md: recommend shallow threading of cover letters #6429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
taahol wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −5
Open

CONTRIBUTING.md: recommend shallow threading of cover letters #6429

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ you can fix quickly, or if anything catches your eye.

You can also look at [the unofficial Chromium issues page](https://crbug.com/git) for
multi-platform issues. You can look at recent user questions on
[the Git mailing list](https://public-inbox.org/git).
[the Git mailing list](https://lore.kernel.org/git).

Or you can "scratch your own itch", i.e. address an issue you have with Git. The team at Microsoft where the Git for Windows maintainer works, for example, is focused almost entirely on [improving performance](https://blogs.msdn.microsoft.com/devops/2018/01/11/microsofts-performance-contributions-to-git-in-2017/).
We approach our work by finding something that is slow and try to speed it up. We start our
Expand Down Expand Up @@ -332,7 +332,7 @@ Submit Your Patch

Git for Windows [accepts pull requests on GitHub](https://github.com/git-for-windows/git/pulls), but
these are reserved for Windows-specific improvements. For core Git, submissions are accepted on
[the Git mailing list](https://public-inbox.org/git).
[the Git mailing list](https://lore.kernel.org/git).

### Configure Git to Send Emails

Expand Down Expand Up @@ -367,8 +367,8 @@ To construct a patch set, use the `git format-patch` command. There are three im
`git branch --edit-description`, you will end up with a 0/N mail with that description and
a nice overall diffstat.
* `--in-reply-to=[Message-ID]`: This will mark your cover letter as replying to the given
message (which should correspond to your previous iteration). To determine the correct Message-ID,
find the message you are replying to on [public-inbox.org/git](https://public-inbox.org/git) and take
message (which should correspond to your first iteration). To determine the correct Message-ID,
find the message you are replying to on [lore.kernel.org/git](https://lore.kernel.org/git) and take
the ID from between the angle brackets.

* `--subject-prefix=[prefix]`: This defaults to [PATCH]. For subsequent iterations, you will want to
Expand Down Expand Up @@ -413,5 +413,5 @@ To submit a nth version patch (say version 3):

```
git send-email --to=git@vger.kernel.org --cc=<email1> --cc=<email2> \
--in-reply-to=<the message id of cover letter of patch v2> [dir with patches]/*.patch
--in-reply-to=<the message id of cover letter of patch v1> [dir with patches]/*.patch
```