Fix diff filtering for uppercase extensions and recursive patterns - #178
Open
a3ylf wants to merge 1 commit into
Open
Fix diff filtering for uppercase extensions and recursive patterns#178a3ylf wants to merge 1 commit into
a3ylf wants to merge 1 commit into
Conversation
abhinavgautam01
approved these changes
Sep 10, 2026
abhinavgautam01
left a comment
abhinavgautam01
left a comment
Contributor
There was a problem hiding this comment.
Reviewed the implementation and regression coverage. Both fixes address #176 correctly, including deeply nested paths and zero-directory ** matches. I verified that the new tests fail before the fix and pass afterward...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brief diffdrops R, R Markdown, and mkmf detections when changed files have uppercase extensions or match a recursive pattern across multiple directories. Normalize pattern extensions to match the changed-extension lookup, and reuse the existing recursive path matcher.Adds regression coverage for nested
.Rand.Rmdfiles, zero/deep**matches, and ordinary wildcard matches and misses. Both new tests fail before the fix and pass afterward.Fixes #176.
Validation:
go build ./...,go test -race ./..., and golangci-lint 2.13.2 (0 issues).Prepared with AI assistance.