Skip to content

refactor(storage): extract webhook configuration stores - #5278

Draft
edersonbrilhante wants to merge 18 commits into
refactor-runner-config-storage-providerfrom
refactor-webhook-matcher-config-storage
Draft

refactor(storage): extract webhook configuration stores#5278
edersonbrilhante wants to merge 18 commits into
refactor-runner-config-storage-providerfrom
refactor-webhook-matcher-config-storage

Conversation

@edersonbrilhante

@edersonbrilhante edersonbrilhante commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Description

  • add provider-neutral RunnerMatcherConfigStore and GitHubWebhookSecretStore capabilities selected through the existing runner-config storage provider
  • move SSM matcher chunk loading, webhook-secret lookup, parameter paths, and backend error handling into the AWS SSM adapters
  • update webhook configuration and tests to mock the storage abstractions without importing SSM
  • remove the webhook package's direct aws-ssm-util dependency

This is a stacked PR based on #5277. It contains no Terraform or termination-watcher changes.

Test Plan

  • full Lambda Vitest suite: 60 files, 908 tests
  • storage-provider suite: 11 files, 92 tests
  • webhook suite: 7 files, 84 tests
  • TypeScript checks for storage-providers and webhook
  • focused ESLint and Prettier checks
  • yarn install --immutable
  • production webhook NCC bundle
  • git diff --check
  • CodeGuard review for secret handling and log redaction

Related Issues

@github-actions

Copy link
Copy Markdown
Contributor

Dependency Review

The following issues were found:
  • ✅ 0 vulnerable package(s)
  • ✅ 0 package(s) with incompatible licenses
  • ✅ 0 package(s) with invalid SPDX license definitions
  • ⚠️ 1 package(s) with unknown licenses.
See the Details below.

License Issues

lambdas/functions/webhook/package.json

PackageVersionLicenseIssue Type
@aws-github-runner/storage-providersNullUnknown License

OpenSSF Scorecard

PackageVersionScoreDetails
npm/@aws-github-runner/storage-providers UnknownUnknown

Scanned Files

  • lambdas/functions/webhook/package.json

@edersonbrilhante edersonbrilhante changed the title refactor(storage): extract webhook matcher config refactor(storage): extract webhook configuration stores Aug 19, 2026
@edersonbrilhante
edersonbrilhante force-pushed the refactor-runner-config-storage-provider branch from 4726813 to c2a8566 Compare August 19, 2026 13:59
@edersonbrilhante
edersonbrilhante force-pushed the refactor-webhook-matcher-config-storage branch from 0150fb2 to 365ec35 Compare August 19, 2026 14:13
@edersonbrilhante
edersonbrilhante force-pushed the refactor-runner-config-storage-provider branch from c2a8566 to 47b53cb Compare August 19, 2026 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant