Unified: use link_deps for native deps of swift_syntax_rs - #22569
Merged
Merged
Conversation
`rules_rust` deprecated C++ libraries in `deps`, warning on every build. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The targeted migration matches rules_rust semantics and preserves existing linkage behavior.
Review tier: Balanced
Findings: None
What changed in this PR
Moves Swift native FFI dependencies to the supported rules_rust attribute while preserving linker ordering.
Changes:
- Replaces
depswithlink_depsfor native Swift/C++ dependencies. - Eliminates the
rules_rustdeprecation warning.
| File | Description |
|---|---|
unified/swift-syntax-rs/BUILD.bazel |
Uses link_deps for native dependencies. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rules_rustnow warns on every build that C++ libraries indepsare deprecated and will stop working:All entries in that
selectareCcInfo-only targets (the two linker-groupcc_libraryshims and theswift_libraryFFI shim), so they move wholesale tolink_deps.rules_rustappendslink_depsafterdepsand preserves list order, so the--start-group/--end-groupsequencing is unaffected.Verified
bazel aquerylink arguments forswift-syntax-parseare byte-identical before and after, under both the default and thestatic_swift_runtimeplatform.