Conversation
hvitved
force-pushed
the
unbound-list-unicode-encoding
branch
from
September 17, 2026 13:14
5f786b9 to
73bae65
Compare
hvitved
changed the title
hvitved
force-pushed
the
unbound-list-unicode-encoding
branch
from
September 17, 2026 15:11
3034640 to
39850bc
Compare
hvitved
force-pushed
the
unbound-list-unicode-encoding
branch
from
September 17, 2026 15:36
39850bc to
449e377
Compare
hvitved
marked this pull request as ready for review
September 17, 2026 17:56
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The encoding emits a redundant zero digit for every element, undermining the intended compactness.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Replaces decimal element IDs with compact printable ASCII encoding in UnboundList.
Changes:
- Adds base-94 encoding excluding the
.separator. - Generalizes list regex operations to support nonnumeric encodings.
| File | Description |
|---|---|
shared/util/codeql/util/UnboundList.qll |
Implements ASCII encoding and updates parsing regexes. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+72
to
+76
| exists(int mid | | ||
| mid = getAsciiCodePart(e, i - 1) and | ||
| mid > 0 and | ||
| result = mid / asciiCodes() | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A small change to use ASCII base encoding instead of base 10; I also tried Unicode encoding (first commit), but that didn't work (presumably because they do not work with the various regex operations). I recommend reviewing the two commits combined.
DCA is uneventful.