Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused implementation is consistent with the stated goal and covers relevant boundary cases.
Review effort: Balanced
Findings: None
What changed in this PR
Adds a compatibility floor for outdated Rust nightly toolchains.
Changes:
- Caps dated nightlies older than 2026-07-15.
- Preserves rolling, current, and unrecognized nightly toolchains.
- Adds unit tests for selection behavior and test-toolchain synchronization.
| File | Description |
|---|---|
rust/extractor/src/toolchain.rs |
Implements and tests minimum-nightly selection. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
hvitved
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently when a project specifies a nightly toolchain we always use the nightly toolchain as-is.
This PR adds a minimum date below which we cap the nightly toolchain. So, loosely speaking, nightly toolchains become
max(specified-nightly, minimum-nightly).This improves extraction for projects that use an old nightly toolchain. I don't think this matters much in practice, but it should result in less noise in DCA and QA. Hopefully I'll also make #22559 a true noop.
DCA looks great and shows that we extract way more from Databend and Rendiation.