Remove documentation for unavailable tool-search command - #3162
Merged
Conversation
Wire the documented tool-search subcommand to the existing discovery engine and configured inventory. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Registers the documented tool-search CLI command and connects it to the existing filtered tool inventory.
Changes:
- Adds configurable tool search with result limits and TTY-aware color.
- Tests registration, filtering, feature flags, and output.
- Restores color dependencies and generated license metadata.
Show a summary per file
| File | Description |
|---|---|
cmd/github-mcp-server/tool_search.go |
Implements and registers tool search. |
cmd/github-mcp-server/tool_search_test.go |
Tests command behavior and filtering. |
go.mod |
Adds the color dependency. |
go.sum |
Records dependency checksums. |
third-party-licenses.darwin.md |
Updates macOS license inventory. |
third-party-licenses.linux.md |
Updates Linux license inventory. |
third-party-licenses.windows.md |
Updates Windows license inventory. |
third-party/github.com/fatih/color/LICENSE.md |
Adds dependency license. |
third-party/github.com/mattn/go-colorable/LICENSE |
Adds dependency license. |
third-party/github.com/mattn/go-isatty/LICENSE |
Adds dependency license. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 9/10 changed files
- Comments generated: 0
- Review effort level: Balanced
Remove the CLI section that advertised a subcommand the binary does not provide. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: f1d58829-0794-4caa-aa18-86543d177609
tommaso-moro
changed the title
RossTarrant
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the README section advertising the unavailable
tool-searchCLI command.Why
Fixes #3161
The binary has never registered this subcommand, so the documented examples fail with an unknown-command error. There is no established requirement to expand the CLI surface, making removal of the inaccurate documentation the narrower fix.
What changed
tool-searchdescription and examples from the README.MCP impact
Prompts tested (tool changes only)
Security / limits
Tool renaming
deprecated_tool_aliases.goNote: if you're renaming tools, you must add the new tool aliases in
deprecated_tool_aliases.go. For more information, see the official docs.Lint & tests
./script/lint./script/testDocs