fix: add OpenWorldHint to default-on UGC issue/PR/discussion tools - #3260
Draft
tiagovilasboas wants to merge 1 commit into
Draft
fix: add OpenWorldHint to default-on UGC issue/PR/discussion tools#3260tiagovilasboas wants to merge 1 commit into
tiagovilasboas wants to merge 1 commit into
Conversation
…n tools Clients that require an explicit boolean (same class of gap as ReadOnlyHint) cannot treat omitted OpenWorldHint as the spec default of true. Granular issue/PR tools already declare OpenWorldHint: true; the always-on counterparts that return or publish issue, PR, review, and discussion user-generated content did not. Scope is limited to that default-on UGC surface and does not change search tools, matching the github#1100 decision to postpone a broad OSS rollout. Co-authored-by: Tiago Vilas Boas <tcarvalhovb@gmail.com>
Author
|
Hi — first-time contributor here. Could a maintainer please approve and run the pending workflows when you have a moment? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add an explicit
OpenWorldHint: trueto the always-on issue, pull request, and discussion tools that return or publish user-generated content, matching the annotation already shipped on granular issue/PR tools.Why
MCP clients that require a real boolean (the same class of gap as
ReadOnlyHintin #2483) cannot treat an omittedOpenWorldHintas the spec default oftrue. That leaves the default-on UGC path unannotated while feature-flagged granular siblings already declareOpenWorldHint: true.#1100 postponed a broad OSS rollout because adding the hint to search tools on the remote server was disruptive. This PR is a narrow slice: default-on issue/PR/discussion UGC only. Search tools and closed-world getters are unchanged.
Related: #1100 (postponed broad OSS OpenWorldHint), granular tools on main, stalled broad #1700.
What changed
issue_read,issue_write,add_issue_commentpull_request_read,pull_request_review_write,add_comment_to_pending_review,add_reply_to_pull_request_commentget_discussion,get_discussion_comments,discussion_comment_write__toolsnaps__updatesMCP impact
Annotations only. Clients that honor explicit
openWorldHint: truecan now prompt before fetching or publishing untrusted issue/PR/discussion content. Spec-compliant clients that already default omitted totruesee no semantic change.Prompts tested (tool changes only)
Security / limits
AppSec: issue/PR/discussion bodies and comments are untrusted UGC. An explicit open-world hint lets permission gates treat that surface as external data instead of a closed, trusted domain.
Tool renaming
deprecated_tool_aliases.goLint & tests
./script/lint./script/testFocused
pkg/githubannotation/toolsnap tests andTestAllToolRegistrationsExplicitlySetReadOnlyHintpassed. Full./script/test/ lint status will be reflected in CI.Docs