fix(skills): match closing frontmatter delimiter on its own line - #3739
Open
Quratulain-bilal wants to merge 2 commits into
Open
fix(skills): match closing frontmatter delimiter on its own line#3739Quratulain-bilal wants to merge 2 commits into
Quratulain-bilal wants to merge 2 commits into
Conversation
SkillsIntegration.setup parsed each command template's frontmatter with
raw.split("---", 2). A bare substring split stops at the first `---`
*anywhere*, so a template whose description embeds `---` (e.g.
"Separate sections with --- markers") truncated the parsed frontmatter:
later keys were dropped, the description fell back to the generic default,
and the leftover frontmatter spilled into the skill body.
Scan for the closing `---` on its own line instead, for both the
description parse and the body strip. The frontmatter block is parsed
unstripped so trailing newlines in literal (|) block scalars still survive,
and the body slice keeps the newline after the marker so output stays
byte-for-byte identical to the old split for well-formed templates.
Adds regression tests covering the dashed-description truncation and the
frontmatter-spilled-into-body cases.
Contributor
There was a problem hiding this comment.
Pull request overview
Hardens skills frontmatter parsing so embedded --- values do not truncate metadata or spill into the body.
Changes:
- Adds line-anchored closing-delimiter detection.
- Adds regression tests for dashed descriptions and body integrity.
Show a summary per file
| File | Description |
|---|---|
src/specify_cli/integrations/base.py |
Hardens skills frontmatter parsing and stripping. |
tests/integrations/test_skill_frontmatter_quoting.py |
Tests embedded-dash handling. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 2/2 changed files
- Comments generated: 2
- Review effort level: Medium
Comment on lines
+1640
to
+1644
| fm_close = next( | ||
| ( | ||
| i | ||
| for i in range(1, len(fm_lines)) | ||
| if fm_lines[i].rstrip() == "---" |
| if fm_close is not None: | ||
| try: | ||
| fm = yaml.safe_load(parts[1]) | ||
| fm = yaml.safe_load("".join(fm_lines[1:fm_close])) |
mnriem
requested changes
Jul 27, 2026
mnriem
left a comment
mnriem
left a comment
Collaborator
There was a problem hiding this comment.
Please address Copilot feedback
Hermes overrides SkillsIntegration.setup() with its own copy of the
frontmatter parse and body strip, and Kimi's _is_speckit_generated_skill()
parses frontmatter independently, so all three carried the same
split("---", 2) bug the base class just fixed. A description such as
"Separate sections with --- markers" truncates the parsed frontmatter at the
embedded marker, dropping later keys and spilling the remainder into the
body; for Kimi that means a Speckit-generated skill is no longer recognized
on teardown and gets left behind.
Scan for a closing "---" on its own line instead. The body slice keeps
whatever trails the marker so output stays byte-for-byte identical for
well-formed templates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
SkillsIntegration.setupparses each command template's frontmatter withraw.split("---", 2). A bare substring split stops at the first---anywhere — including one embedded inside a value. A template whose description contains---, e.g.is mis-parsed three ways:
Separate sections with(or dropped entirely, falling back to the genericSpec Kit: <name> workflow);Fix
Locate the closing
---on its own line (line-anchored scan) for both the description parse and the body strip, mirroring the hardenedCommandRegistrar.parse_frontmatterscan.|) block scalars still survive.split("---", 2)[2]for well-formed templates (verified with a differential check across normal / empty-body / trailing-space cases).Tests
Adds
TestSkillFrontmatterEmbeddedDashescovering the dashed-description truncation and the frontmatter-spilled-into-body cases. Both fail on the pre-fix code and pass after. Full skills integration suite: 342 passed, 3 skipped, 0 failures.