fix(extensions): tolerate non-string catalog name in display-name lookup

[Noor-ul-ain001]

@

Summary

_resolve_catalog_extension() (used by extension info <name> and extension add <name>) resolves an argument to a catalog entry by display name:

search_results = catalog.search(query=argument)
name_matches = [ext for ext in search_results if ext["name"].lower() == argument.lower()]

Extension catalog JSON is user-editable, so catalog.search() can return an entry whose name is a non-string. A hand-authored name: 123 crashes the filter:

AttributeError: int object has no attribute lower

which takes down extension info <name> / extension add <name> with a raw traceback. A missing name key would similarly raise KeyError.

Notably, the ambiguous-match display block a few lines below already str()-coerces the name (_escape_markup(str(ext.get("name", "")))) — so the code already acknowledges name may be non-string/absent; only the filter line missed it.

Fix

Coerce defensively with str(ext.get("name", "")).lower(), matching that sibling block. A bad-named entry simply fails to match, producing a clean not-found error instead of a traceback. Same bug class as the presets fix in #3743.

Testing

Adds test_add_by_name_tolerates_non_string_catalog_name, which invokes extension info <name> against a mocked catalog whose search result has name: 123. It fails pre-fix with AttributeError and passes after; the existing display-name resolution test stays green.

🤖 Generated with Claude Code
@

[Copilot]

Pull request overview

Hardens extension display-name lookup against malformed catalog names.

Changes:

• Coerces catalog names before case-insensitive comparison.
• Adds a regression test for numeric names.

Show a summary per file

File	Description
src/specify_cli/extensions/_commands.py	Hardens display-name matching.
tests/test_extensions.py	Adds malformed-name coverage.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

• Files reviewed: 2/2 changed files
• Comments generated: 2
• Review effort level: Medium

[Copilot]

Review details

Comments suppressed due to low confidence (2)

src/specify_cli/extensions/_commands.py:173

• This comment says the argument is passed as a search query, but the call now deliberately fetches all entries. That distinction is important: ExtensionCatalog.search(query=...) joins the user-editable name into searchable text and can raise TypeError before this defensive filter runs. Document why the no-query call is required so it is not “corrected” back into the production crash.

        # Try by display name - search using argument as query, then filter for exact match.
        # Coerce name defensively: catalog JSON is user-editable, so a hand-authored
        # non-string/missing name must not crash the match (the ambiguous-match display
        # below already str()-coerces name for the same reason).
        search_results = catalog.search()

tests/test_extensions.py:6556

• These assertions accept any raw failure other than AttributeError, so a TypeError/KeyError traceback still passes despite the promised clean not-found path. The MagicMock also accepts both search(query=...) and search(), leaving the production-critical no-query behavior unguarded. Assert the expected CLI output and exact catalog call.

        # match, so resolution ends as a clean not-found error exit.
        assert not isinstance(result.exception, AttributeError), (
            f"non-string catalog name crashed resolution: {result.exception!r}"
        )
        assert result.exit_code != 0

• Files reviewed: 2/2 changed files
• Comments generated: 1
• Review effort level: Medium

[mnriem]

Please address Copilot feedback

[Copilot]

Review details

Comments suppressed due to low confidence (2)

src/specify_cli/extensions/_commands.py:172

• This comment no longer describes the implementation: catalog.search() is deliberately called without argument because the real search implementation tries to join the malformed name before this filter runs. Please document that unfiltered lookup so a future cleanup does not restore the crashing query=argument call.

        # Try by display name - search using argument as query, then filter for exact match.
        # Coerce name defensively: catalog JSON is user-editable, so a hand-authored
        # non-string/missing name must not crash the match (the ambiguous-match display
        # below already str()-coerces name for the same reason).

tests/test_extensions.py:6556

• These assertions do not establish the promised clean not-found path: a KeyError, TypeError, or another raw exception would still satisfy both. The mock also returns the same data for search(query=...), so the test would miss reintroducing the real catalog's pre-filter crash while joining a numeric name. Assert the user-facing error and that search was called without a query.

        assert not isinstance(result.exception, AttributeError), (
            f"non-string catalog name crashed resolution: {result.exception!r}"
        )
        assert result.exit_code != 0

• Files reviewed: 2/2 changed files
• Comments generated: 0 new
• Review effort level: Medium