fix: make converge coverage auditable - #3754
Open
cadugevaerd wants to merge 1 commit into
Open
Conversation
Require artifact-derived per-category coverage, expose stable inventory keys, and fail closed before appending tasks when assessment is incomplete. Closes github#3752 Assisted-by: Hermes Agent (model: gpt-5.6-terra, autonomous)
Contributor
There was a problem hiding this comment.
Pull request overview
Adds auditable convergence coverage and fail-closed handling for incomplete assessments.
Changes:
- Adds per-category coverage metrics and stable-key ledgers.
- Introduces
incomplete_assessment. - Documents and tests all three outcomes.
Show a summary per file
| File | Description |
|---|---|
templates/commands/converge.md |
Defines coverage, ledger, and outcome rules. |
docs/reference/agentic-sdd.md |
Documents the new outcome contract. |
tests/test_converge_template_contract.py |
Adds template regression tests. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 3/3 changed files
- Comments generated: 2
- Review effort level: Medium
| - Buildable SCs checked: `<checked>/<total>` | ||
| - Acceptance scenarios checked: `<checked>/<total>` | ||
| - Plan decisions checked: `<checked>/<total>` | ||
| - Constitution MUST principles checked: `<checked>/<total>` (or `skipped — template`) |
Comment on lines
+32
to
+35
| "Constitution MUST principles checked: `<checked>/<total>`", | ||
| ): | ||
| assert metric in content | ||
|
|
mnriem
requested changes
Jul 27, 2026
mnriem
left a comment
mnriem
left a comment
Collaborator
There was a problem hiding this comment.
Please address Copilot feedback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/speckit.convergeemit artifact-derivedchecked/totalcoverage per category and a stable-key ledgerincomplete_assessmentbefore appending tasks when any required key is unassessedValidation
python -m pytest tests -q— 5438 passed, 7 skippedmarkdownlint-cli2 templates/commands/converge.md docs/reference/agentic-sdd.md— 0 issuesincomplete_assessment,tasks_appended, andconvergedpaths; the final converged pass lefttasks.mdunchangedCloses #3752