fix: handle tags containing / in GitHub release asset URL resolution - #3767
Merged
mnriem merged 1 commit intoJul 28, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes release asset resolution for GitHub tags containing literal /.
Changes:
- Reconstructs the tag from all path segments before the asset filename.
- Treats the final segment as the asset name.
Show a summary per file
| File | Description |
|---|---|
src/specify_cli/_github_http.py |
Corrects tag and asset extraction from release URLs. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Medium
mnriem
requested changes
Jul 27, 2026
mnriem
left a comment
mnriem
left a comment
Collaborator
There was a problem hiding this comment.
Please address Copilot feedback
The tag extraction in resolve_github_release_asset_api_url split the URL path on / and assumed the tag was a single segment at index 4. Tags containing literal / (e.g. feature/v1) would be split across multiple segments, causing the tag to be truncated to only the first part and the asset name to include leftover tag segments. Fix by reconstructing the tag as all segments between 'download' and the final asset segment: tag = '/'.join(parts[4:-1]), asset = parts[-1].
Quratulain-bilal
force-pushed
the
fix/github-http-tag-extraction
branch
from
July 27, 2026 22:24
1b912ba to
7d156c4
Compare
mnriem
self-requested a review
July 28, 2026 20:45
mnriem
approved these changes
Jul 28, 2026
Collaborator
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The tag extraction in resolve_github_release_asset_api_url split the URL path on / and assumed the tag was a single path segment at index 4. Tags containing literal / (e.g. feature/v1) would be split across multiple segments, causing the tag to be truncated.
Example
For URL https://github.com/owner/repo/releases/download/feature/v1.0.0/asset.zip
Changes
Testing
All 30 tests in test_github_http.py pass.