fix(integrations): escape catalog metadata in discovery output - #3772
Open
marcelsafin wants to merge 1 commit into
Open
fix(integrations): escape catalog metadata in discovery output#3772marcelsafin wants to merge 1 commit into
marcelsafin wants to merge 1 commit into
Conversation
Assisted-by: GitHub Copilot (model: GPT-5.6 Sol, autonomous) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Escapes untrusted integration catalog metadata before Rich rendering in discovery commands.
Changes:
- Escapes metadata displayed by
integration searchandintegration info. - Preserves raw IDs for registry and installed-integration lookups.
- Adds regression coverage for markup-like catalog values.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/specify_cli/integrations/_query_commands.py |
Escapes catalog-derived Rich output. |
tests/integrations/test_cli.py |
Tests literal rendering of markup-like metadata. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
src/specify_cli/integrations/_query_commands.py:381
safe_integration_idis only used when the catalog lookup succeeds. The not-found branch still interpolates the rawintegration_idat line 461, sospecify integration info '[red]missing[/red]'continues to interpret the queried ID as Rich markup instead of displaying it literally. Reuse the escaped value in that branch and cover the missing-ID case as well.
safe_integration_id = _rich_escape(str(integration_id))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Integration catalog values are untrusted JSON data, but
integration searchand
integration infointerpolated them directly into Rich output. Bracketedvalues were interpreted as markup and silently lost their literal formatting.
This routes catalog-derived IDs, names, versions, descriptions, authors,
licenses, tags, repository URLs, and source names through the module's existing
_rich_escapehelper while preserving trusted status styling and lookup logic.Regression tests assign distinct Rich tags to every rendered field and verify
that each value survives literally in both commands.
Testing
uv run specify --helpuv sync && uv run pytestFull suite: 5423 passed, 172 skipped.
AI Disclosure
GitHub Copilot (GPT-5.6 Sol) autonomously identified, implemented, tested, and
self-reviewed this change on behalf of @marcelsafin.