Read VS Code Electron version from .npmrc - #4549
Merged
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
VS Code no longer consistently declares Electron in its root package.json. Prefer that declaration for older releases and fall back to the Electron target in .npmrc for newer releases. Validate the resolved version and cover both metadata layouts. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: c8ecd08e-7635-4742-b943-e0fc528b7949
cklin
force-pushed
the
cklin/electron-ver-from-npm
branch
from
September 15, 2026 19:56
e4cf492 to
a1b7714
Compare
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No unresolved review comments remain, and tests cover both lookup paths.
Review tier: Lite (auto)
Findings: None
Note
Copilot is running an experiment and ran this review at Lite.
What changed in this PR
Updates VS Code Electron version discovery so workflows support releases that define it in .npmrc.
Changes:
- Added
.npmrcparsing withpackage.jsonfallback. - Added shared text/JSON fetch handling.
- Added unit tests for both lookup paths.
| File | Description |
|---|---|
extensions/ql-vscode/test/unit-tests/scripts/util/vscode-versions.test.ts |
Tests Electron version discovery paths. |
extensions/ql-vscode/scripts/util/vscode-versions.ts |
Resolves Electron versions from package metadata or .npmrc. |
extensions/ql-vscode/scripts/util/fetch.ts |
Adds reusable response and text-fetching helpers. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
kaspersv
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes broken
update-node-version.ymlworkflow runs by reading the VS Code electron version from.npmrc.