Primer branding: remove purple glow effect on landing page - #284
Merged
Merged
Conversation
The Primer Brand page-design guidance (via the primer-brand MCP server's primer_brand_page_design tool) explicitly lists 'no glows, purple gradients, ... or glassmorphism' as a visual-verification requirement. The landing page's .landing-glow element combined a blurred (filter: blur(28px)), animated radial-gradient mixing --agent-purple-rgb, --accent-blue-rgb, and --accent-green-rgb behind the hero heading — an off-brand glow/gradient effect. Removed the .landing-glow element, its CSS rule, the @Property thermo-*-x/y custom properties and thermoDrift keyframes that only powered it, and the now-unused prefers-reduced-motion override for it. No other markup, logic, or tests depend on this element. npm test: 326/327 pass (pre-existing, unrelated failure in copilot-instructions.test.js due to a stale generated_at date vs. patterns/manifest.json — confirmed present before this change). npm run build: succeeds via vite build (the prebuild vendor-asset fetch fails only because this sandbox has no network access to npm registry, a pre-existing environment limitation unrelated to this change). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Color / visual effects
.landing-glowdecorative background on the landing page (src/index.html,src/styles/style.css). It was afilter: blur(28px)animated radial-gradient combining--agent-purple-rgb,--accent-blue-rgb, and--accent-green-rgbbehind the hero heading.@property --thermo-warm-x/-y/--thermo-cool-x/-ycustom properties, thethermoDriftkeyframes, and theprefers-reduced-motionoverride that existed solely to animate this glow.Brand guidance cited
From the
primer-brandMCP server'sprimer_brand_page_designtool (visual-verification checklist, bundled snapshot of@primer/react-brand@0.76.0):The landing glow was exactly this: a blurred, purple-tinted gradient used as ambient decoration behind hero text — an off-brand pattern the guidance explicitly calls out to avoid.
Deviations found but not fixed (follow-ups)
.landing-diagramand.ld-phase-icon-multiuseborder-radius: 999px(pill shapes). The same guidance discourages "pill buttons," but these are non-interactive diagram chips, not buttons, and reworking them risked a larger visual/layout change beyond a focused pass. Left as a follow-up for a dedicated review.--agent-purple, used for the AI-assistant button and copy-success modal) is a Primer product/system color (--color-done-emphasis), not a raw hex value, and is used sparingly (not as a gradient or glow) to signal AI-assisted actions — judged on-brand as-is.primer-branddocs/tokens endpoints in this environment only exposed component-level guidance (Button, page-design checklist, color/type-scale token values) rather than full prose guideline pages (several doc paths returned "could not read"). No hard-coded pixel spacing or off-scale type deviations were found that could be traced to a specific retrieved guideline within that constraint, so no changes were made in those categories this pass.Validation
npm test: 326/327 pass. The 1 failing test (copilot-instructions.test.js) fails identically onmainbefore this change (verified viagit stash) — a stalegenerated_atdate mismatch unrelated to this PR.npm run build: theprebuildvendor-asset fetch (scripts/fetch-vendor-assets.mjs) fails only because this sandbox has no network access to the npm registry — a pre-existing environment limitation. Runningnpx vite builddirectly (skipping only the network-dependent vendor step) succeeds cleanly and confirms the HTML/CSS changes compile and render correctly.Warning
Firewall blocked 1 domain
The following domain was blocked by the firewall during workflow execution:
registry.npmjs.orgTo allow these domains, add them to the
network.allowedlist in your workflow frontmatter:See Network Configuration for more information.