Fix TypeScript index signatures for mixed properties - #3127
Open
yhuikzdtguioaert wants to merge 1 commit into
Open
Fix TypeScript index signatures for mixed properties#3127yhuikzdtguioaert wants to merge 1 commit into
yhuikzdtguioaert wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3123.
What changed
TypeScript now widens a typed
additionalPropertiesindex signature with the declared property types. If any declared property is optional, the index signature also includesundefined, which is required bytsc --strict.The ordinary unconstrained
additionalPropertiespath remains unchanged (any/unknown), so common generated output does not gain redundant unions. Flow keeps its existing rendering through the base hook.A JSON Schema fixture includes both a valid mixed object and an invalid additional property, covering generation, strict compilation, successful conversion, and runtime rejection.
Verification
npm run build— passed--just-typesoutput +tsc --ignoreConfig --noEmit --strict— passed for default,--prefer-types, and--prefer-unknownbiome checkfor all changed source/fixture files — passed