Proactive desktop notification for the deletion guard - #205
Merged
Conversation
added 6 commits
September 8, 2026 16:54
…-notification # Conflicts: # README.es.md # README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #203. Ports the proactive desktop-notification flow from PyNextCloud-Sync
0.1.32to the deletion guard.When the guard pauses synchronization on a mass local deletion, the app now raises a critical desktop notification (urgency
Critical) with a Review Now button that opens the deletion review directly, even when the app runs only in the tray. Previously the state was only reflected in the tray/UI and the user was never proactively notified.Changes
core/notifications.rs: addDesktopNotifier::send_delete_review(summary, body, on_action)— raises a criticalnotify-rustnotification with a "Review Now" action and fireson_actionon a worker thread.core/scheduler.rs: add adelete_review_cbhook (set_on_delete_review) fired with the alert on raise and cleared on approve/restore/stop.ui/main_window.rs:install_delete_review_handler: wires the hook per folder, builds the copy, and routes "Review Now" back to the review through anmpscchannel + a main-loop poller (a non-SendwindowWeakcannot cross the notifier thread).main.rs: wire the handler after the window is built.Validation
login_flow),clippy --all-targets -D warningsandcargo fmtclean.