DP-3630 Give dark-theme prev/next hyperlinks a distinct ink from active-nav lime - #112
Draft
claude[bot] wants to merge 1 commit into
Draft
DP-3630 Give dark-theme prev/next hyperlinks a distinct ink from active-nav lime#112claude[bot] wants to merge 1 commit into
claude[bot] wants to merge 1 commit into
Conversation
In dark theme, the prev/next-page navigation link reused $color-lime-green, the exact color used for the active sidebar-nav state, so a reader could not tell "where I am" from "where I can go" by color alone. Switch the link to $color-ice-blue (the palette's existing "Hyperlinks on dark backgrounds" token, already used by inline body links), keeping the pre-existing underline as the non-color differentiator per WCAG 1.4.1. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Hfa29EmE8trdLXwnszcXxe
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested via Slack thread
What / why
DP-3630 (https://gooddata.atlassian.net/browse/DP-3630): in dark theme, the prev/next-page hyperlink (
.gd-docs-prev-next-pages__link) and the active sidebar-nav state (.gd-docs-menu-page.active ... __link) both used the identical$color-lime-green, so the two affordances ("where I am" vs. "where I can go") were indistinguishable by color alone.Light theme already keeps these distinct (
$color-blackfor active nav vs.$color-linkfor the prev/next link) — this only affects the dark-theme override.Change
assets/scss/dark-theme/prev-next-pages.scss:&__linkcolor:$color-lime-green->$color-ice-blue(the palette's existing "Hyperlinks on dark backgrounds" token — already used by the genericaselector indark-theme/typography.scss, so this reuses an established, already-vetted brand token rather than introducing a new color).$color-white->$color-alice-blue, matching the hover token generic body links already use in dark theme.Active-nav lime (
dark-theme/menu.scss) is left untouched, per the ticket's proposed fix direction (keep lime for the active-nav affordance).Acceptance criteria from the ticket
$color-ice-blue, the same token already used (and implicitly covered by the prior AA audit) for standard dark-theme hyperlinks — avoids the previously-unsampled lime-link contrast combination entirely rather than needing a fresh contrast measurement.Test plan
assets/scss/prev-next-pages.scss).