[bot] Merge master/9103989f into rel/dev - #1730
Merged
Merged
Conversation
Drill is being removed from the backend (F1-2434), so the SDK no longer needs to model it. Unlike Greenplum there was never a hand-written `CatalogDataSourceDrill` class, so there is nothing to drop from `gooddata_sdk` exports and no test or docs example to remove. Two prose mentions of Drill as a multi-schema data source manager are reworded to Dremio only. The generated client was updated the supported way in spirit rather than by hand-rolling a new shape: the `DRILL` enum entry was removed from the two source schemas it originates from -- gooddata-metadata-client.json and gooddata-scan-client.json -- and from the six generated models that mirror them, which is exactly the six-file, one-line-each shape regeneration produces (the same shape the Greenplum removal produced). The merged schemas/gooddata-api-client.json was edited line-wise instead of being rebuilt through the Makefile's `jq -S -s` step. jq 1.6 does not preserve number literals and rewrote unrelated values (2.6E+9 -> 2600000000, 1.0 -> 1) across the file; the checked-in copy was produced with jq 1.7+, which does. `ENABLE_DRILL_TO_URL_BY_DEFAULT` is a drill-to-URL setting, unrelated to Apache Drill, and is left untouched. JIRA: F1-2434 risk: low
refactor: remove support for Drill
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## rel/dev #1730 +/- ##
========================================
Coverage 79.15% 79.15%
========================================
Files 271 271
Lines 18794 18794
========================================
Hits 14876 14876
Misses 3918 3918 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Automated PR to perform merge from master into rel/dev with changes up to 9103989 (created by https://github.com/gooddata/gooddata-python-sdk/actions/runs/31484195968).