Skip to content

Add App Check support for macOS - #615

Open
fardanagroup wants to merge 1 commit into
google:mainfrom
fardanagroup:fardanagroup-issue-602-add-app-check-support-for-macos-a42071
Open

Add App Check support for macOS#615
fardanagroup wants to merge 1 commit into
google:mainfrom
fardanagroup:fardanagroup-issue-602-add-app-check-support-for-macos-a42071

Conversation

@fardanagroup

Copy link
Copy Markdown

Why
Add macOS support to the Firebase App Check integration so GoogleSignIn can compile and run App Check code paths on macOS builds. This enables safer usage of App Check where platform support exists and provides consistent behavior across Apple platforms.

What changed

  • Widen Objective-C preprocessor guards to include TARGET_OS_OSX so App Check implementation, fake provider, error definitions, and unit tests are available on macOS.
  • Files updated: GIDAppCheck.h, GIDAppCheck.m, GIDAppCheckProviderFake.h, GIDAppCheckProviderFake.m, GIDAppCheckError.h, GIDAppCheckTest.m.

Approach
Used conservative conditional compilation to avoid changing behavior on iOS while enabling macOS compilation. No API surface or runtime behavior changes beyond making the App Check code available when building for macOS. Tests were adjusted to compile on macOS by exposing the test file under macOS builds.

Notes for reviewers

  • This change only widens compilation availability; macOS runtime entitlements (App Attest availability, keychain access groups) may require additional platform-specific configuration in consumer apps. Documented limitations should be added if needed in follow-ups.

Fixes: #602

Include TARGET_OS_OSX in Objective-C platform guards so App Check implementation, fake provider, error definitions, and tests compile on macOS.
@google-cla

google-cla Bot commented Aug 7, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@fardanagroup

Copy link
Copy Markdown
Author

Automated check failure: cla/google failed. The Google CLA must be signed for the committing GitHub account before CLA checks can pass. Please sign the CLA at https://cla.developers.google.com/ and then push a new commit or an empty commit to re-trigger CI. If you need help reproducing locally, note the local swift build failed due to a Swift tools/version mismatch (requires Swift 6 / Xcode 15).

@fardanagroup

Copy link
Copy Markdown
Author

Quick CI triage:

  • cla/google: failure — Missing CLA. Action needed: please sign the Google CLA: https://cla.developers.google.com/about
  • Build GSI for Valid Architectures, Google GitHub Admin: Actions Workflow Security Scan, integration_tests, unit_tests: all show 'action_required' and their logs are not accessible to me. Reason: this PR is from a fork (fardanagroup/GoogleSignIn-iOS) so org/workflow policies require admin approval to run workflows on forked PRs.

What I tried locally:

  • swift build failed to parse/validate the Package.swift manifest in this environment (linker error referencing PackageDescription symbols). So I couldn't reproduce CI runs locally.

Next steps for the contributor/maintainers:

  1. Contributor: sign the CLA at the link above.
  2. Repo admins: approve workflow runs for this PR (or advise maintainer to re-run). Once workflows run, if any failures are truly code-caused I will fix them in this PR.

If you want me to re-run local checks or attempt fixes, tell me and I will proceed.

@fardanagroup

Copy link
Copy Markdown
Author

Maintainers/admins: This PR is from a fork and several workflow runs are 'action_required' and blocked by organization workflow approval. Please approve the workflow runs so CI can execute:

  1. Go to the Actions run listed under Checks on the PR (or Actions tab).
  2. For each run marked 'action_required', click 'Review and approve' (or 'Approve and run jobs') to allow the job to execute for this fork.

Also: the cla/google check failed because the contributor account needs to sign the Google CLA at https://cla.developers.google.com/. After CLA is signed and the workflows are approved, CI should re-run. If you want me to re-triage failures afterward, I can fix any code-caused issues.

@w-goog

w-goog commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

@fardanagroup - it appears you have an LLM posting on your behalf. Please sign the CLA before proceeding, or we will close this CL :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add App Check support for macOS

2 participants