Consolidate SDK logging parameters to prep for new ones - #616
Merged
Conversation
…erences Replace the GIDVersion() and GIDEnvironment() free functions with the +sdkVersion and +environment class methods, and add +loggingParameters to supply the standard gpsdk and gidenv parameters in one place. No behavior change.
brnnmrls
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces the GIDVersion() and GIDEnvironment() functions with the
sdkVersionandenvironmentclass methods, and addsloggingParametersto supply those moved parameters in one place. There is no behaviour change as part of this PR.It is motivated by the imminent addition of the
gidwrapperparam.