Skip to content

Fix similarity score for binaries without flow graph edges #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zunnurawan wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix similarity score for binaries without flow graph edges #91

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions differ.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -550,11 +550,17 @@ double GetSimilarityScore(const CallGraph& call_graph1,
const CallGraph& call_graph2,
const Histogram& histogram, const Counts& counts) {
double similarity = 0;
similarity +=
0.35 * counts[Counts::kFlowGraphEdgeMatchesNonLibrary] /
(std::max(1.0,
0.5 * (counts[Counts::kFlowGraphEdgesPrimaryNonLibrary] +
counts[Counts::kFlowGraphEdgesSecondaryNonLibrary])));
const int edges_primary = counts[Counts::kFlowGraphEdgesPrimaryNonLibrary];
const int edges_secondary =
counts[Counts::kFlowGraphEdgesSecondaryNonLibrary];
if (edges_primary == 0 && edges_secondary == 0) {
// When neither side has any flow graph edges, there is nothing to disagree
// about, and the edge term is a full match.
similarity += 0.35;
} else {
similarity += 0.35 * counts[Counts::kFlowGraphEdgeMatchesNonLibrary] /
(std::max(1.0, 0.5 * (edges_primary + edges_secondary)));
}
similarity +=
0.25 * counts[Counts::kBasicBlockMatchesNonLibrary] /
(std::max(1.0, 0.5 * (counts[Counts::kBasicBlocksPrimaryNonLibrary] +
Expand Down