references: correct the exclusive-reference speaker note for NLL - #3243
Open
rmyndharis wants to merge 1 commit into
Open
references: correct the exclusive-reference speaker note for NLL#3243rmyndharis wants to merge 1 commit into
rmyndharis wants to merge 1 commit into
Conversation
The note suggested accessing `point.0` "while x_coord is alive", but under non-lexical lifetimes the mutable borrow of `point.0` ends at the last use of `x_coord` (`*x_coord = 20;`). Accessing `point.0` after that line therefore compiles and no longer demonstrates the restriction. Reword the note to explain that a borrow lasts until its last use, and to insert the conflicting access before that last use to reproduce the borrow error. Closes google#2246.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The note suggested accessing
point.0"while x_coord is alive", but undernon-lexical lifetimes the mutable borrow of
point.0ends at the last useof
x_coord(*x_coord = 20;). Accessingpoint.0after that linetherefore compiles and no longer demonstrates the restriction. Reword the
note to explain that a borrow lasts until its last use, and to insert the
conflicting access before that last use to reproduce the borrow error.
Closes #2246.