feat!: Add Copilot content exclusion set and enterprise endpoints - #4527
Open
Tens1des wants to merge 2 commits into
Open
feat!: Add Copilot content exclusion set and enterprise endpoints#4527Tens1des wants to merge 2 commits into
Tens1des wants to merge 2 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4527 +/- ##
=======================================
Coverage 98.53% 98.53%
=======================================
Files 195 195
Lines 17848 17875 +27
=======================================
+ Hits 17587 17614 +27
Misses 261 261 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
gmlewis
reviewed
Sep 7, 2026
|
|
||
| // CopilotOrganizationContentExclusionDetails is an alias for organization-scoped | ||
| // content exclusion rules. Prefer CopilotContentExclusionDetails for new code. | ||
| type CopilotOrganizationContentExclusionDetails = CopilotContentExclusionDetails |
Collaborator
There was a problem hiding this comment.
Why do we need two types representing the same thing?
Are you doing this just to prevent a breaking API change?
I'm fine with breaking (and documenting) the API change and just use the same renamed type for both.
Thoughts?
Contributor
Author
There was a problem hiding this comment.
Yes, the alias was only to avoid a breaking rename. Dropped it and kept a single CopilotContentExclusionDetails type, with a NOTE Breaking API change in the docs. Also updating the PR title to feat!:.
Contributor
There was a problem hiding this comment.
Please remove the NOTE for consistency with other breaking changes. We provide info about breaking changes in a PR's description.
Remove CopilotOrganizationContentExclusionDetails alias and keep a single CopilotContentExclusionDetails type, as requested in review.
Tens1des
changed the title
gmlewis
added
the
Breaking API Change
gmlewis
approved these changes
Sep 7, 2026
alexandear
suggested changes
Sep 8, 2026
Comment on lines
+396
to
+397
| // | ||
| // NOTE Breaking API change: renamed from CopilotOrganizationContentExclusionDetails. |
Contributor
There was a problem hiding this comment.
This is not needed:
Suggested change
| // | |
| // NOTE Breaking API change: renamed from CopilotOrganizationContentExclusionDetails. |
| // GitHub API docs: https://docs.github.com/rest/copilot/copilot-content-exclusion-management?apiVersion=2022-11-28#set-copilot-content-exclusion-rules-for-an-organization | ||
| // | ||
| //meta:operation PUT /orgs/{org}/copilot/content_exclusion | ||
| func (s *CopilotService) SetOrganizationContentExclusionDetails(ctx context.Context, org string, body CopilotContentExclusionDetails) (*CopilotContentExclusionUpdateResponse, *Response, error) { |
Contributor
There was a problem hiding this comment.
Suggested change
| func (s *CopilotService) SetOrganizationContentExclusionDetails(ctx context.Context, org string, body CopilotContentExclusionDetails) (*CopilotContentExclusionUpdateResponse, *Response, error) { | |
| func (s *CopilotService) SetOrganizationContentExclusionDetails(ctx context.Context, org string, body CopilotSetContentExclusionDetailsRequest) (*CopilotSetContentExclusionResponse, *Response, error) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
CopilotOrganizationContentExclusionDetailsis nowCopilotContentExclusionDetails.Summary
Fixes #4526
Test plan
go test ./github/ -run ContentExclusion./script/fmt.shand./script/generate.shCopilotOrganizationContentExclusionDetails→CopilotContentExclusionDetails